Changeset 1184 for XIOS

Timestamp:

06/26/17 16:44:24 (7 years ago)

Author:

oabramkina

Message:

Two server levels: correcting buffer allocations on client side of primary server. The buffer size is calculated according to the number of files sent to each secondary server.

Location:

XIOS/dev/dev_olga/src

Files:

• context_client.cpp (modified) (1 diff)
• node/context.cpp (modified) (8 diffs)
• node/context.hpp (modified) (1 diff)
• server.cpp (modified) (1 diff)

XIOS/dev/dev_olga/src/context_client.cpp

@@ -94 +94 @@
         list<CBufferOut*> buffList;
         bool couldBuffer = getBuffers(ranks, sizes, buffList, (!CXios::isClient && (CServer::serverLevel == 0) ));
-        //bool couldBuffer = getBuffers(ranks, sizes, buffList, false );
+//        bool couldBuffer = getBuffers(ranks, sizes, buffList, CXios::isServer );
 
         if (couldBuffer)

XIOS/dev/dev_olga/src/node/context.cpp

@@ -289 +289 @@
    }
 
-   void CContext::setClientServerBuffer()
+   void CContext::setClientServerBuffer(CContextClient* contextClient)
    {
      size_t minBufferSize = CXios::minBufferSize;
@@ -300 +300 @@
 
      std::map<int, StdSize> maxEventSize;
-     std::map<int, StdSize> bufferSize = getAttributesBufferSize(maxEventSize);
-     std::map<int, StdSize> dataBufferSize = getDataBufferSize(maxEventSize);
+     std::map<int, StdSize> bufferSize = getAttributesBufferSize(maxEventSize, contextClient);
+     std::map<int, StdSize> dataBufferSize = getDataBufferSize(maxEventSize, contextClient);
 
      std::map<int, StdSize>::iterator it, ite = dataBufferSize.end();
@@ -319 +319 @@
        if (it->second < minBufferSize) it->second = minBufferSize;
 
-     if (client->isServerLeader())
-     {
-       const std::list<int>& ranks = client->getRanksServerLeader();
+     if (contextClient->isServerLeader())
+     {
+       const std::list<int>& ranks = contextClient->getRanksServerLeader();
        for (std::list<int>::const_iterator itRank = ranks.begin(), itRankEnd = ranks.end(); itRank != itRankEnd; ++itRank)
          if (!bufferSize.count(*itRank)) bufferSize[*itRank] = maxEventSize[*itRank] = minBufferSize;
      }
-     client->setBufferSize(bufferSize, maxEventSize);
-
-     // If it is primary server pool, also set buffer for clientPrimServer.
-     if (hasClient && hasServer)
-     {
-       for (int i = 0; i < clientPrimServer.size(); ++i)
-       {
-         if (clientPrimServer[i]->isServerLeader())
-         {
-           const std::list<int>& ranks = clientPrimServer[i]->getRanksServerLeader();
-           for (std::list<int>::const_iterator itRank = ranks.begin(), itRankEnd = ranks.end(); itRank != itRankEnd; ++itRank)
-             if (!bufferSize.count(*itRank)) bufferSize[*itRank] = maxEventSize[*itRank] = minBufferSize;
-         }
-         clientPrimServer[i]->setBufferSize(bufferSize, maxEventSize);
-       }
-     }
+     contextClient->setBufferSize(bufferSize, maxEventSize);
+
    }
 
@@ -536 +522 @@
      checkGridEnabledFields();    
 
-     setClientServerBuffer();
+     setClientServerBuffer(client);
+     if (hasServer)
+       for (int i = 0; i < clientPrimServer.size(); ++i)
+         setClientServerBuffer(clientPrimServer[i]);
+
 
      if (hasClient)
@@ -1197 +1187 @@
     * \param maxEventSize [in/out] the size of the bigger event for each connected server
     */
-   std::map<int, StdSize> CContext::getAttributesBufferSize(std::map<int, StdSize>& maxEventSize)
+   std::map<int, StdSize> CContext::getAttributesBufferSize(std::map<int, StdSize>& maxEventSize, CContextClient* contextClient)
    {
      std::map<int, StdSize> attributesSize;
@@ -1207 +1197 @@
        {
          CFile* file = this->enabledFiles[i];
-
-         std::vector<CField*> enabledFields = file->getEnabledFields();
-         size_t numEnabledFields = enabledFields.size();
-         for (size_t j = 0; j < numEnabledFields; ++j)
+         if (file->getContextClient() == contextClient)
          {
-           const std::map<int, StdSize> mapSize = enabledFields[j]->getGridAttributesBufferSize();
-           std::map<int, StdSize>::const_iterator it = mapSize.begin(), itE = mapSize.end();
-           for (; it != itE; ++it)
+           std::vector<CField*> enabledFields = file->getEnabledFields();
+           size_t numEnabledFields = enabledFields.size();
+           for (size_t j = 0; j < numEnabledFields; ++j)
            {
-             // If attributesSize[it->first] does not exist, it will be zero-initialized
-             // so we can use it safely without checking for its existance
-             if (attributesSize[it->first] < it->second)
-               attributesSize[it->first] = it->second;
-
-             if (maxEventSize[it->first] < it->second)
-               maxEventSize[it->first] = it->second;
+             const std::map<int, StdSize> mapSize = enabledFields[j]->getGridAttributesBufferSize();
+             std::map<int, StdSize>::const_iterator it = mapSize.begin(), itE = mapSize.end();
+             for (; it != itE; ++it)
+             {
+               // If attributesSize[it->first] does not exist, it will be zero-initialized
+               // so we can use it safely without checking for its existance
+               if (attributesSize[it->first] < it->second)
+                 attributesSize[it->first] = it->second;
+
+               if (maxEventSize[it->first] < it->second)
+                 maxEventSize[it->first] = it->second;
+             }
            }
          }
@@ -1236 +1228 @@
     * \param maxEventSize [in/out] the size of the bigger event for each connected server
     */
-   std::map<int, StdSize> CContext::getDataBufferSize(std::map<int, StdSize>& maxEventSize)
+   std::map<int, StdSize> CContext::getDataBufferSize(std::map<int, StdSize>& maxEventSize, CContextClient* contextClient)
    {
      CFile::mode_attr::t_enum mode = hasClient ? CFile::mode_attr::write : CFile::mode_attr::read;
@@ -1247 +1239 @@
      {
        CFile* file = this->enabledFiles[i];
-       CFile::mode_attr::t_enum fileMode = file->mode.isEmpty() ? CFile::mode_attr::write : file->mode.getValue();
-
-       if (fileMode == mode)
+       if (file->getContextClient() == contextClient)
        {
-         std::vector<CField*> enabledFields = file->getEnabledFields();
-         size_t numEnabledFields = enabledFields.size();
-         for (size_t j = 0; j < numEnabledFields; ++j)
+         CFile::mode_attr::t_enum fileMode = file->mode.isEmpty() ? CFile::mode_attr::write : file->mode.getValue();
+
+         if (fileMode == mode)
          {
-           const std::vector<std::map<int, StdSize> > mapSize = enabledFields[j]->getGridDataBufferSize();
-           for (size_t c = 0; c < mapSize.size(); ++c)
+           std::vector<CField*> enabledFields = file->getEnabledFields();
+           size_t numEnabledFields = enabledFields.size();
+           for (size_t j = 0; j < numEnabledFields; ++j)
            {
-             std::map<int, StdSize>::const_iterator it = mapSize[c].begin(), itE = mapSize[c].end();
-             for (; it != itE; ++it)
+             const std::vector<std::map<int, StdSize> > mapSize = enabledFields[j]->getGridDataBufferSize();
+             for (size_t c = 0; c < mapSize.size(); ++c)
              {
-               // If dataSize[it->first] does not exist, it will be zero-initialized
-               // so we can use it safely without checking for its existance
-               if (CXios::isOptPerformance)
-                 dataSize[it->first] += it->second;
-               else if (dataSize[it->first] < it->second)
-                 dataSize[it->first] = it->second;
-
-               if (maxEventSize[it->first] < it->second)
-                 maxEventSize[it->first] = it->second;
+               std::map<int, StdSize>::const_iterator it = mapSize[c].begin(), itE = mapSize[c].end();
+               for (; it != itE; ++it)
+               {
+                 // If dataSize[it->first] does not exist, it will be zero-initialized
+                 // so we can use it safely without checking for its existance
+                 if (CXios::isOptPerformance)
+                   dataSize[it->first] += it->second;
+                 else if (dataSize[it->first] < it->second)
+                   dataSize[it->first] = it->second;
+
+                 if (maxEventSize[it->first] < it->second)
+                   maxEventSize[it->first] = it->second;
+               }
              }
            }

XIOS/dev/dev_olga/src/node/context.hpp

@@ -131 +131 @@
          void sendGridEnabledFields();
 
-         std::map<int, StdSize> getAttributesBufferSize(std::map<int, StdSize>& maxEventSize);
-         std::map<int, StdSize> getDataBufferSize(std::map<int, StdSize>& maxEventSize);
-         void setClientServerBuffer();
+//         std::map<int, StdSize> getAttributesBufferSize(std::map<int, StdSize>& maxEventSize);
+//         std::map<int, StdSize> getDataBufferSize(std::map<int, StdSize>& maxEventSize);
+//         void setClientServerBuffer();
+         std::map<int, StdSize> getAttributesBufferSize(std::map<int, StdSize>& maxEventSize, CContextClient* contextClient);
+         std::map<int, StdSize> getDataBufferSize(std::map<int, StdSize>& maxEventSize, CContextClient* contextClient);
+         void setClientServerBuffer(CContextClient* contextClient);
 
          // Send context close definition

XIOS/dev/dev_olga/src/server.cpp

@@ -267 +267 @@
           interCommLeft.push_back(newComm) ;
         }
-        delete [] srvGlobalRanks ;
-
-              oasis_enddef() ;
+        if (CXios::usingServer2) delete [] srvGlobalRanks ;
+        oasis_enddef() ;
       }
+
 
       MPI_Comm_rank(intraComm, &rank) ;