Changeset 1191


Ignore:
Timestamp:
07/03/17 14:34:21 (4 years ago)
Author:
rlacroix
Message:

Do not use the "min_buffer_size" parameter also as maximum event size.

Using the "min_buffer_size" as maximum event size caused the maximum number of bufferable events to be completely underestimated which could affect performance.

The new solution is not perfect either as it overestimates the maximum number of bufferable events in most cases. In theory this could cause deadlocks but in practice it should be mostly safe.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • XIOS/trunk/src/node/context.cpp

    r1190 r1191  
    290290       if (it->second < minBufferSize) it->second = minBufferSize; 
    291291     } 
    292  
    293      // We consider that the minimum buffer size is also the minimum event size 
    294      ite = maxEventSize.end(); 
    295      for (it = maxEventSize.begin(); it != ite; ++it) 
    296        if (it->second < minBufferSize) it->second = minBufferSize; 
    297292 
    298293     client->setBufferSize(bufferSize, maxEventSize); 
Note: See TracChangeset for help on using the changeset viewer.