Changeset 511 for XIOS

Timestamp:

11/13/14 15:09:28 (9 years ago)

Author:

mhnguyen

Message:

Seperating database of context on "client" side and "server" side

+) Add one more context in contex client in case of attached mode
+) Do some minor changements to make sure everything fine in case of attached mode
+) Replace buffer group with the new options

Test
+) On Curie
+) Connection mode: Attached and seperated
+) File mode: one and multiple
+) All tests passed

Location:

XIOS/trunk

Files:

• inputs/iodef.xml (modified) (2 diffs)
• src/client.cpp (modified) (5 diffs)
• src/context_client.cpp (modified) (4 diffs)
• src/context_client.hpp (modified) (2 diffs)
• src/context_server.cpp (modified) (2 diffs)
• src/context_server.hpp (modified) (2 diffs)
• src/cxios.cpp (modified) (3 diffs)
• src/cxios.hpp (modified) (2 diffs)
• src/node/context.cpp (modified) (9 diffs)
• src/node/context.hpp (modified) (3 diffs)
• src/node/grid.cpp (modified) (1 diff)
• src/object.cpp (modified) (2 diffs)
• src/object.hpp (modified) (1 diff)
• src/object_template_impl.hpp (modified) (1 diff)

XIOS/trunk/inputs/iodef.xml

@@ -10 +10 @@
     
     
-   <file_definition type="multiple_file" par_access="collective" output_freq="6h" output_level="10" enabled=".TRUE.">
+   <file_definition type="one_file" par_access="collective" output_freq="6h" output_level="10" enabled=".TRUE.">
      <file id="output" name="output"> 
         <field field_ref="field_A" />
@@ -41 +41 @@
       <variable_definition>
         <variable_group id="buffer">
-            buffer_size = 80000000
-            buffer_server_factor_size = 2 
+            <variable id="optimal_buffer_size" type="string">performance</variable>
+            <variable id="buffer_factor_size" type="double">1.0</variable> 
          </variable_group>
 
         <variable_group id="parameters" >
           <variable id="using_server" type="boolean">false</variable>
-          <variable id="info_level" type="int">50</variable>
+          <variable id="info_level" type="int">10</variable>
+          <variable id="print_file" type="boolean">true</variable>
         </variable_group>
       </variable_definition>

XIOS/trunk/src/client.cpp

@@ -132 +132 @@
         CTimer::get("XIOS").resume() ;
         CTimer::get("XIOS init").resume() ;
-  
-        if (CXios::usingServer) 
+
+        if (CXios::usingServer)
         {
           MPI_Status status ;
@@ -153 +153 @@
     {
       CContext::setCurrent(id) ;
-      CContext* context=CContext::create(id) ;
+      CContext* context=CContext::create(id);
+      StdString idServer(id);
+      idServer += "_server";
 
       if (!CXios::isServer)
@@ -169 +171 @@
 
         CMessage msg ;
-        msg<<id<<size<<globalRank ;
+        msg<<idServer<<size<<globalRank ;
+//        msg<<id<<size<<globalRank ;
 
         int messageSize=msg.size() ;
@@ -192 +195 @@
         MPI_Comm contextInterComm ;
         MPI_Comm_dup(contextComm,&contextInterComm) ;
-        context->initClient(contextComm,contextInterComm) ;
-        context->initServer(contextComm,contextInterComm) ;
+        CContext* contextServer = CContext::create(idServer);
+
+        // Firstly, initialize context on client side
+        context->initClient(contextComm,contextInterComm, contextServer);
+
+
+        // Secondly, initialize context on server side
+        contextServer->initServer(contextComm,contextInterComm);
+
+        // Finally, we should return current context to context client
+        CContext::setCurrent(id);
+//        context->initServer(contextComm,contextInterComm) ;
       }
     }
@@ -223 +236 @@
       report(0)<< " Performance report : Ratio : "<< CTimer::get("Blocking time").getCumulatedTime()/CTimer::get("XIOS").getCumulatedTime()*100.<<" %"<<endl ;
       report(0)<< " Performance report : This ratio must be close to zero. Otherwise it may be usefull to increase buffer size or numbers of server"<<endl ;
-      report(0)<< " Memory report : Current buffer_size : "<<CXios::bufferSize<<endl ;
-      report(0)<< " Memory report : Minimum buffer size required : "<<maxRequestSize*2<<endl ;
+//      report(0)<< " Memory report : Current buffer_size : "<<CXios::bufferSize<<endl ;
+      report(0)<< " Memory report : Minimum buffer size required : "<<maxRequestSize*2<< " bytes" << endl ;
       report(0)<< " Memory report : increasing it by a factor will increase performance, depending of the volume of data wrote in file at each time step of the file"<<endl ;
    }

XIOS/trunk/src/context_client.cpp

@@ -17 +17 @@
 
 
-    CContextClient::CContextClient(CContext* parent,MPI_Comm intraComm_, MPI_Comm interComm_) : mapBufferSize_()
+    CContextClient::CContextClient(CContext* parent,MPI_Comm intraComm_, MPI_Comm interComm_, CContext* cxtSer)
+     : mapBufferSize_(), parentServer(cxtSer)
     {
       context=parent ;
@@ -61 +62 @@
       }
 
-      if (context->hasServer) waitEvent(ranks) ;
+//      if (context->hasServer)
+      if (0 != parentServer)
+      {
+        waitEvent(ranks);
+        CContext::setCurrent(context->getId());
+      }
+
       timeLine++ ;
     }
@@ -92 +99 @@
     void CContextClient::waitEvent(list<int>& ranks)
     {
-      context->server->setPendingEvent() ;
+//      context->server->setPendingEvent() ;
+//      while(checkBuffers(ranks))
+//      {
+//        context->server->listen() ;
+//        context->server->checkPendingRequest() ;
+//      }
+//
+//      while(context->server->hasPendingEvent())
+//      {
+//       context->server->eventLoop() ;
+//      }
+
+      parentServer->server->setPendingEvent() ;
       while(checkBuffers(ranks))
       {
-        context->server->listen() ;
-        context->server->checkPendingRequest() ;
-      }
-
-      while(context->server->hasPendingEvent())
-      {
-       context->server->eventLoop() ;
+        parentServer->server->listen() ;
+        parentServer->server->checkPendingRequest() ;
+      }
+
+      while(parentServer->server->hasPendingEvent())
+      {
+       parentServer->server->eventLoop() ;
       }
 
@@ -240 +259 @@
      }
      CTimer::get("Blocking time").suspend();
-     report(0)<< " Memory report : Context <"<<context->getId()<<"> : client side : total memory used for buffer "<<buffers.size()*CXios::bufferSize<<" bytes"<<endl ;
+//     report(0)<< " Memory report : Context <"<<context->getId()<<"> : client side : total memory used for buffer "<<buffers.size()*CXios::bufferSize<<" bytes"<<endl ;
+
+     std::map<int, StdSize>::const_iterator itbMap = mapBufferSize_.begin(),
+                                            iteMap = mapBufferSize_.end(), itMap;
+     StdSize totalBuf = 0;
+     for (itMap = itbMap; itMap != iteMap; ++itMap)
+     {
+       report(10)<< " Memory report : Context <"<<context->getId()<<"> : client side : memory used for buffer of each connection to server" << endl
+                 << "  +)To server with rank " << itMap->first << " : " << itMap->second << " bytes " << endl;
+       totalBuf += itMap->second;
+     }
+     report(0)<< " Memory report : Context <"<<context->getId()<<"> : client side : total memory used for buffer "<<totalBuf<<" bytes"<<endl ;
 
      releaseBuffers() ;

XIOS/trunk/src/context_client.hpp

@@ -16 +16 @@
 
     public:
-    CContextClient(CContext* parent,MPI_Comm intraComm, MPI_Comm interComm) ;
+    CContextClient(CContext* parent,MPI_Comm intraComm, MPI_Comm interComm, CContext* parentServer = 0) ;
 //    void registerEvent(CEventClient& event) ;
 
@@ -48 +48 @@
     private:
     std::map<int, StdSize> mapBufferSize_;
+    CContext* parentServer;
 //    bool locked ;
 

XIOS/trunk/src/context_server.cpp

@@ -83 +83 @@
             StdSize buffSize = 0;
             MPI_Recv(&buffSize, 1, MPI_LONG, rank, 20, interComm, &status);
+            mapBufferSize_.insert(std::make_pair(rank, buffSize));
             it=(buffers.insert(pair<int,CServerBuffer*>(rank,new CServerBuffer(buffSize)))).first ;
           }
@@ -207 +208 @@
     {
       info(20)<<"Server Side context <"<<context->getId()<<"> finalized"<<endl ;
+      std::map<int, StdSize>::const_iterator itbMap = mapBufferSize_.begin(),
+                                             iteMap = mapBufferSize_.end(), itMap;
+      StdSize totalBuf = 0;
+      for (itMap = itbMap; itMap != iteMap; ++itMap)
+      {
+        report(10)<< " Memory report : Context <"<<context->getId()<<"> : server side : memory used for buffer of each connection to client" << endl
+                  << "  +) With client of rank " << itMap->first << " : " << itMap->second << " bytes " << endl;
+        totalBuf += itMap->second;
+      }
       context->finalize() ;
       finished=true ;
-      report(0)<< " Memory report : Context <"<<context->getId()<<"> : server side : total memory used for buffer "<<buffers.size()*CXios::bufferSize<<" bytes"<<endl ;
+      report(0)<< " Memory report : Context <"<<context->getId()<<"> : server side : total memory used for buffer "<<totalBuf<<" bytes"<<endl ;
     }
     else if (event.classId==CContext::GetType()) CContext::dispatchEvent(event) ;

XIOS/trunk/src/context_server.hpp

@@ -9 +9 @@
 {
   class CContext ;
-  
+
   class CContextServer
   {
     public:
-    
+
     CContextServer(CContext* parent,MPI_Comm intraComm,MPI_Comm interComm) ;
     bool eventLoop(void) ;
@@ -23 +23 @@
     void setPendingEvent(void) ;
     bool hasPendingEvent(void) ;
-    
+
     MPI_Comm intraComm ;
     int intraCommSize ;
     int intraCommRank ;
-    
+
     MPI_Comm interComm ;
     int commSize ;
-  
+
     map<int,CServerBuffer*> buffers ;
     map<int,MPI_Request> pendingRequest ;
     map<int,char*> bufferRequest ;
-    
+
     map<size_t,CEventServer*> events ;
     size_t currentTimeLine ;
     CContext* context ;
-    
+
     bool finished ;
     bool pendingEvent ;
     bool scheduled  ;    /*!< event of current timeline is alreading scheduled ? */
     size_t hashId ;
-    ~CContextServer() ;    
+    ~CContextServer() ;
+
+    private:
+      std::map<int, StdSize> mapBufferSize_;
   } ;
 

XIOS/trunk/src/cxios.cpp

@@ -29 +29 @@
   bool CXios::printInfo2File;
   bool CXios::isServerSide;
-
+  bool CXios::isOptPerformance = true;
 
   void CXios::initialize()
@@ -35 +35 @@
     set_new_handler(noMemory);
     parseFile(rootFile);
+    parseXiosConfig();
+  }
+
+  void CXios::parseXiosConfig()
+  {
     usingOasis=getin<bool>("using_oasis",false) ;
     usingServer=getin<bool>("using_server",false) ;
     info.setLevel(getin<int>("info_level",0)) ;
+    report.setLevel(getin<int>("info_level",0));
     printInfo2File=getin<bool>("print_file",false);
     bufferSize=getin<size_t>("buffer_size",defaultBufferSize) ;
-    bufferServerFactorSize=getin<double>("buffer_server_factor_size",defaultBufferServerFactorSize) ;
+    StdString bufMemory("memory");
+    StdString bufPerformance("performance");
+    StdString bufOpt = getin<StdString>("optimal_buffer_size", bufPerformance);
+    std::transform(bufOpt.begin(), bufOpt.end(), bufOpt.begin(), ::tolower);
+    if (0 == bufOpt.compare(bufMemory)) isOptPerformance = false;
+    else if (0 != bufOpt.compare(bufPerformance))
+    {
+      ERROR("CXios::parseXiosConfig()", << "optimal_buffer_size must be memory or performance "<< endl );
+    }
+
+//    bufferServerFactorSize=getin<double>("buffer_server_factor_size",defaultBufferServerFactorSize) ;
+    bufferServerFactorSize=getin<double>("buffer_factor_size",defaultBufferServerFactorSize) ;
     globalComm=MPI_COMM_WORLD ;
   }
-
 
   void CXios::initClientSide(const string& codeId, MPI_Comm& localComm, MPI_Comm& returnComm)
@@ -79 +95 @@
     parseList.insert("xios");
     xml::CXMLParser::ParseFile(rootFile, parseList);
-//    parseFile(rootFile);
-    usingOasis=getin<bool>("using_oasis",false) ;
-    info.setLevel(getin<int>("info_level",0)) ;
-    printInfo2File=getin<bool>("print_file",false);
-    bufferSize=getin<size_t>("buffer_size",defaultBufferSize) ;
-    bufferServerFactorSize=getin<double>("buffer_server_factor_size",defaultBufferServerFactorSize) ;
-    globalComm=MPI_COMM_WORLD ;
-
+    parseXiosConfig();
   }
 

XIOS/trunk/src/cxios.hpp

@@ -42 +42 @@
      static double bufferServerFactorSize ;
      static double defaultBufferServerFactorSize ;
+     static bool isOptPerformance;
 
      public:
@@ -54 +55 @@
 
      static  void initServer();
+
+     private:
+      static void parseXiosConfig();
 
   } ;

XIOS/trunk/src/node/context.cpp

@@ -23 +23 @@
    CContext::CContext(void)
       : CObjectTemplate<CContext>(), CContextAttributes()
-      , calendar(),hasClient(false),hasServer(false), isPostProcessed(false), dataSize_()
+      , calendar(),hasClient(false),hasServer(false), isPostProcessed(false), dataSize_(), idServer_()
    { /* Ne rien faire de plus */ }
 
    CContext::CContext(const StdString & id)
       : CObjectTemplate<CContext>(id), CContextAttributes()
-      , calendar(),hasClient(false),hasServer(false), isPostProcessed(false), dataSize_()
+      , calendar(),hasClient(false),hasServer(false), isPostProcessed(false), dataSize_(), idServer_()
    { /* Ne rien faire de plus */ }
 
@@ -280 +280 @@
 
    //! Initialize client side
-   void CContext::initClient(MPI_Comm intraComm, MPI_Comm interComm)
+   void CContext::initClient(MPI_Comm intraComm, MPI_Comm interComm, CContext* cxtServer)
    {
      hasClient=true ;
-     client = new CContextClient(this,intraComm, interComm) ;
+     client = new CContextClient(this,intraComm, interComm, cxtServer) ;
    }
 
@@ -575 +575 @@
      {
        CMessage msg ;
-       msg<<this->getId() ;
+       msg<<this->getIdServer() ;
        event.push(client->getServerLeader(),1,msg) ;
        client->sendEvent(event) ;
@@ -601 +601 @@
        {
          CMessage msg ;
-         msg<<this->getId()<<step ;
+         msg<<this->getIdServer()<<step ;
          event.push(client->getServerLeader(),1,msg) ;
          client->sendEvent(event) ;
@@ -634 +634 @@
      {
        CMessage msg ;
-       msg<<this->getId() ;
+       msg<<this->getIdServer() ;
        event.push(client->getServerLeader(),1,msg) ;
        client->sendEvent(event) ;
@@ -665 +665 @@
        {
          CMessage msg ;
-         msg<<this->getId();
+         msg<<this->getIdServer();
          event.push(client->getServerLeader(),1,msg) ;
          client->sendEvent(event) ;
@@ -686 +686 @@
    {
       postProcessing();
+   }
+
+   const StdString& CContext::getIdServer()
+   {
+      if (hasClient)
+      {
+        idServer_ = this->getId();
+        idServer_ += "_server";
+        return idServer_;
+      }
+      if (hasServer) return (this->getId());
    }
 
@@ -736 +747 @@
          else
          {
+           std::map<int, StdSize>::const_iterator it = mapSize.begin(), itE = mapSize.end();
            if (domainIds.find(prDomAxisId.first) == domainIds.end())
            {
-             std::map<int, StdSize>::const_iterator it = mapSize.begin(), itE = mapSize.end();
              for (; it != itE; ++it)
              {
@@ -744 +755 @@
                else dataSize_.insert(make_pair(it->first, it->second));
              }
+           } else
+           {
+             for (; it != itE; ++it)
+             {
+               if (0 < dataSize_.count(it->first))
+                if (CXios::isOptPerformance) dataSize_[it->first] += it->second;
+                else
+                {
+                  if (dataSize_[it->first] < it->second) dataSize_[it->first] = it->second;
+                }
+               else dataSize_.insert(make_pair(it->first, it->second));
+             }
            }
-
          }
-
        }
      }

XIOS/trunk/src/node/context.hpp

@@ -88 +88 @@
          // Initialize server or client
          void initServer(MPI_Comm intraComm, MPI_Comm interComm) ;
-         void initClient(MPI_Comm intraComm, MPI_Comm interComm) ;
+         void initClient(MPI_Comm intraComm, MPI_Comm interComm, CContext* cxtServer=0) ;
          bool isInitialized(void) ;
 
@@ -129 +129 @@
          void sendPostProcessing();
 
+         const StdString& getIdServer();
+
          // Client side: Receive and process messages
          static void recvUpdateCalendar(CEventServer& event) ;
@@ -206 +208 @@
          bool isPostProcessed;
          std::map<int, StdSize> dataSize_;
+         StdString idServer_;
 
 

XIOS/trunk/src/node/grid.cpp

@@ -177 +177 @@
        if (this->withAxis) retVal *= this->axis->size.getValue();
        retVal *= sizeof(double);
-       retVal *= 1.2; // Secure factor
+       retVal *= 1.2 * CXios::bufferServerFactorSize; // Secure factor
        ret.insert(make_pair(it->first, retVal));
      }

XIOS/trunk/src/object.cpp

@@ -20 +20 @@
    { /* Ne rien faire de plus */ }
 
-   const StdString & CObject::getId(void) const 
-   { 
+   const StdString & CObject::getId(void) const
+   {
       return (this->id);
    }
 
-   bool CObject::hasId(void) const  
-   { 
+   const StdString& CObject::getIdServer()
+   {
+      return (this->id);
+   }
+
+   bool CObject::hasId(void) const
+   {
       return (this->IdDefined);
    }
 
-   void CObject::resetId(void) 
-   { 
+   void CObject::resetId(void)
+   {
       this->IdDefined = false ;
    }
 
    void CObject::setId(const StdString & id)
-   { 
+   {
       this->id = id ;
       this->IdDefined = true ;
@@ -49 +54 @@
 
    bool CObject::operator!=(const CObject & other) const
-   { 
+   {
       return (!(*this == other));
    }
 */
    StdOStream & operator << (StdOStream & os, const CObject & object)
-   { 
+   {
       os << object.toString();
       return (os);

XIOS/trunk/src/object.hpp

@@ -18 +18 @@
          /// Accesseurs ///
          const StdString & getId(void) const;
+
+         virtual const StdString& getIdServer();
 
          /// Mutateurs ///

XIOS/trunk/src/object_template_impl.hpp

@@ -193 +193 @@
        {
          CMessage msg ;
-         msg<<this->getId() ;
+//         msg<<this->getId() ;
+         msg<<this->getIdServer();
          msg<<attr.getName() ;
          msg<<attr ;