Changeset 1358

Timestamp:

06/25/15 15:38:45 (9 years ago)

Author:

nanardon

Message:

Fix object return detection: stringify return null if _id is unset

Location:

trunk/LATMOS-Accounts

Files:

• lib/LATMOS/Accounts/Bases/Objects.pm (modified) (1 diff)
• t/15_bases_mail.t (modified) (1 diff)

trunk/LATMOS-Accounts/lib/LATMOS/Accounts/Bases/Objects.pm

@@ -78 +78 @@
     # finding perl class:
     my $pclass = $base->_load_obj_class($otype) or return;
-    my $newobj = "$pclass"->new($base, $id, @args) or return;
+    my $newobj = "$pclass"->new($base, $id, @args);
+
+    defined($newobj) or do {
+        $base->log(LA_DEBUG, "$pclass->new() returned undef for $otype / $id");
+        return;
+    };
 
     $newobj->{_base} = $base;

trunk/LATMOS-Accounts/t/15_bases_mail.t

@@ -31 +31 @@
 is( $mailb->attribute('aliases', 'forward')->iname, "forward", "can call get_field_name");
 
-ok(my $alias =  $mailb->get_object('aliases', 'name'),  "Can get root user");
-ok(my $revaliases = $mailb->get_object('revaliases', 'name'), "Can get root group");
+ok(my $alias =  $mailb->get_object('aliases', 'name'),  "Can get alias name");
+ok(my $revaliases = $mailb->get_object('revaliases', 'name'), "Can get revalias name");
 
 is($alias->get_c_field('forward'), 'to', 'Can get aliases');