Changeset 1545

Timestamp:

12/28/15 12:01:15 (8 years ago)

Author:

nanardon

Message:

Ensure a clear message is given on error

Location:

trunk/LATMOS-Accounts/lib/LATMOS/Accounts

Files:

• Bases.pm (modified) (2 diffs)
• Bases/Objects.pm (modified) (1 diff)

trunk/LATMOS-Accounts/lib/LATMOS/Accounts/Bases.pm

@@ -335 +335 @@
     foreach my $cfield (keys %cdata) {
         $self->check_allowed_values($otype, $cfield, $cdata{$cfield}) or do {
-            $self->log(LA_ERR, "Cannot create $otype, wrong value");
+            my $last = LATMOS::Accounts::Log::lastmessage(LA_ERR);
+            $self->log(LA_ERR, "Cannot create $otype, wrong value%s", ($last ? ": $last" : ''));
             return;
         };
@@ -394 +395 @@
 
     if (!$pclass->checkValues($self, $id, %data)) {
+        my $last = LATMOS::Accounts::Log::lastmessage(LA_ERR);
         la_log(LA_ERR,
-            'Cannot create %s (%s) in base %s (%s): wrong values',
-            $id, $otype, $self->label, $self->type
+            'Cannot create %s (%s) in base %s (%s): wrong value%s',
+            $id, $otype, $self->label, $self->type,
+            ($last ? ": $last" : ''),
         );
         return;

trunk/LATMOS-Accounts/lib/LATMOS/Accounts/Bases/Objects.pm

@@ -418 +418 @@
 
     if (!$self->checkValues($self->base, $self, %cdata)) {
+        my $last = LATMOS::Accounts::Log::lastmessage(LA_ERR);
         $self->base->log(LA_ERR,
-            "Cannot update %s (%s): wrong values",
-            $self->id, $self->type
+            "Cannot update %s (%s): wrong value%s",
+            $self->id, $self->type,
+            ($last ? ": $last" : $last)
         );
         return;