Changeset 1594 for trunk

Timestamp:

01/05/16 18:02:38 (9 years ago)

Author:

nanardon

Message:

Refuse object creation if post-setting attribute failed

Location:

trunk

Files:

• LATMOS-Accounts-Web/lib/LATMOS/Accounts/Web/Controller/Create.pm (modified) (2 diffs)
• LATMOS-Accounts/lib/LATMOS/Accounts/Bases.pm (modified) (1 diff)
• LATMOS-Accounts/lib/LATMOS/Accounts/Bases/Sql/objects.pm (modified) (1 diff)

trunk/LATMOS-Accounts-Web/lib/LATMOS/Accounts/Web/Controller/Create.pm

@@ -62 +62 @@
             'Erreur lors de la création de l\'objet: ' .
             LATMOS::Accounts::Log::lastmessage(LA_ERR);
+        $base->rollback;
         foreach my $attr (@{$info->{ask} || []}) {
             my $field = $form->field($attr);
@@ -73 +74 @@
             $c->req->params->{$field->attr_field_name()} = $info->{contents}{$attr};
         }
+        $base->rollback;
     }
     $c->stash->{form} = $form;

trunk/LATMOS-Accounts/lib/LATMOS/Accounts/Bases.pm

@@ -407 +407 @@
         la_log(LA_INFO,
             'Object %s (%s) created in base %s (%s)',
-            $id, $otype, $self->label, $self->type
+            $id, $otype, $self->label, $self->type,
         );
     } else {
+        my $last = LATMOS::Accounts::Log::lastmessage(LA_ERR);
+        warn $last;
         la_log(LA_ERR,
-            'Object creation %s (%s) in base %s (%s) failed',
-            $id, $otype, $self->label, $self->type
+            'Object creation %s (%s) in base %s (%s) failed%s',
+            $id, $otype, $self->label, $self->type,
+            ($last ? ": $last" : ''),
         );
         return;

trunk/LATMOS-Accounts/lib/LATMOS/Accounts/Bases/Sql/objects.pm

@@ -265 +265 @@
     my $res = $sthid->fetchrow_hashref();
     $sthid->finish;
-    $res or return;
+    $res or do {
+        $base->log(LA_DEBUG, 'Cannot retrieve SQL row from freshly create object %s/%s', $class->type, $id);
+        return;
+    };
 
     my $obj = $class->new($base, $res->{k}) or return;
-    $obj->_set_c_fields(%second);
+    if (keys %second) {
+        $obj->_set_c_fields(%second) or do {
+            $base->log(LA_DEBUG, 'Cannot set atttributes to freshly create object %s/%s', $class->type, $id);
+            return;
+        };
+    }
 
     return $res->{k};