Changeset 1600

Timestamp:

01/06/16 18:30:52 (8 years ago)

Author:

nanardon

Message:

Add some check before generating reverse zone

File:

• trunk/LATMOS-Accounts/lib/LATMOS/Accounts/Task/Buildnet.pm (modified) (3 diffs)

trunk/LATMOS-Accounts/lib/LATMOS/Accounts/Task/Buildnet.pm

@@ -551 +551 @@
 
         # reverse is complicated:
-        my $net = $ozone->get_attributes('net');
+        my ($net) = $ozone->get_attributes('net') or do {
+        $self->base->log('Cannot fetch attribute "net" for zone %s', $ozone->id);
+        return;
+    };
         my $netip = Net::IP->new($net) or do {
                 $self->base->log(LA_ERR, "Cannot build reverse zone %s: wrong net %s", $ozone->id, $net);
@@ -578 +581 @@
             } else {
                 # ipv4
+                if ($mask > 24) {
+                    $self->base->log(LA_ERR, 'Mask for zone %s cannot be %d', $ozone->id, $mask);
+                    return;
+                }
                 my @ippart = split(/\./, $res->{value});
                 splice(@ippart, 0, $mask/8); # get rid of start of ip
@@ -589 +596 @@
                 $reverse =~ /\.$/
                     ? ($reverse, ($domain ? "$domain." : '.'))
-                    : ($reverse));
+                    : ($reverse, ''));
         }
     }