Changeset 1698

Timestamp:

02/02/16 05:44:36 (8 years ago)

Author:

nanardon

Message:

Trap empty log message, fix empty log message

Location:

trunk/LATMOS-Accounts/lib/LATMOS/Accounts

Files:

• Bases/Objects.pm (modified) (1 diff)
• Log.pm (modified) (2 diffs)

trunk/LATMOS-Accounts/lib/LATMOS/Accounts/Bases/Objects.pm

@@ -605 +605 @@
         foreach my $field (keys %parsed_filter) {
             $base->attribute($class->type, $field) or
-                la_log LA_WARN "Unsupported attribute $field";
+                la_log(LA_WARN, "Unsupported attribute %s", $field);
             my $tmatch = 0;
             foreach (@{$parsed_filter{$field}}) {

trunk/LATMOS-Accounts/lib/LATMOS/Accounts/Log.pm

@@ -47 +47 @@
 %EXPORT_TAGS = (LOGLEVELS => [ @loglevels ]);
 
-our $VERSION = (q$Rev$ =~ /^Rev: (\d+) /)[0];
+our $VERSION = (q$Rev: 1455 $ =~ /^Rev: (\d+) /)[0];
 
 my %lastmessages = ();
@@ -173 +173 @@
     my ($level, $msg, @args) = @_;
     no warnings 'printf';
+    if (!$msg) {
+        my @call = caller();
+        la_log(LA_WARN, 'empty message at %s:%s', $call[1], $call[2]);
+        return;
+    }
     $lastmessages{$level} = sprintf($msg, map { defined($_) ? $_ : '' } @args);
     if ($log_method{syslog}) {