Changeset 1911 for trunk

Timestamp:

01/04/17 12:16:26 (7 years ago)

Author:

nanardon

Message:

Speed up attribute registration checks

Location:

trunk/LATMOS-Accounts/lib/LATMOS/Accounts/Bases

Files:

• Sql.pm (modified) (3 diffs)
• Sql/objects.pm (modified) (1 diff)

trunk/LATMOS-Accounts/lib/LATMOS/Accounts/Bases/Sql.pm

@@ -98 +98 @@
         $self->log(LA_DEBUG, 'New connection to DB');
 
+
         foreach my $otype ($self->list_supported_objects) {
+            my %attrlist = map { $_ => 1 } $self->list_registered_attributes($otype);
             foreach my $attribute ($self->list_canonical_fields($otype, 'r')) {
                 my $attr = $self->attribute($otype, $attribute);
@@ -104 +106 @@
                 $attr->{managed} and next;
 
-                if ($self->is_registered_attribute($otype, $attribute)) {
+                if ($attrlist{$attribute}) {
                 } else {
                     if($self->register_attribute($otype, $attribute, $attr->{comment})) {
@@ -778 +780 @@
 }
 
+=head2 list_registered_attributes ($otype)
+
+List all regiestered attribute
+
+=cut
+
+sub list_registered_attributes {
+    my ($self, $otype) = @_;
+    my $pclass = $self->_load_obj_class($otype) or return;
+    if ($pclass->_has_extended_attributes) {
+        return $pclass->list_registered_attributes($self);
+    } else {
+        return ();
+    }
+}
+
 =head2 get_attribute_comment ($otype, $attribute)
 

trunk/LATMOS-Accounts/lib/LATMOS/Accounts/Bases/Sql/objects.pm

@@ -1224 +1224 @@
 }
 
+=head2 list_registered_attributes
+
+Return the list for all registered attribute
+
+=cut
+
+sub list_registered_attributes {
+    my ($class, $base) = @_;
+
+    my $sth = $base->db->prepare(
+        sprintf(q{
+            select canonical from %s
+            }, $class->_attributes_table
+        )
+    );
+    $sth->execute();
+    my @attrs = ();
+
+    while (my $res = $sth->fetchrow_hashref) {
+        push(@attrs, $res->{canonical});
+    }
+    return @attrs;
+}
+
+
 =head2 get_attribute_comment $base, $attribute)