Changeset 1938 for trunk

Timestamp:

01/23/17 17:37:48 (7 years ago)

Author:

nanardon

Message:

Don't do useless work

File:

• trunk/LATMOS-Accounts/lib/LATMOS/Accounts/Bases/Sql/Stat.pm (modified) (3 diffs)

trunk/LATMOS-Accounts/lib/LATMOS/Accounts/Bases/Sql/Stat.pm

@@ -187 +187 @@
     my ($self) = @_;
 
+    if (!$self->_get_attributes('needRun')) {
+        return;
+    }
+
     if (my $retention = $self->_get_attributes('retention')) {
         my $limit = DateTime->now->subtract(days => $retention);
@@ -193 +197 @@
             q{ DELETE FROM statsentry where tstamp < ? }
         );
+
         $clean->execute($limit->iso8601);
     }
@@ -198 +203 @@
     my $otype = $self->_get_attributes('otype') or return;
     my $attribute = $self->_get_attributes('attribute') or return;
-
-    if (!$self->_get_attributes('needRun')) {
-        return;
-    }
 
     $self->base->log(LA_NOTICE, "Collecting data for stat: %s", $self->id);