Changeset 2032

Timestamp:

05/10/17 16:32:45 (7 years ago)

Author:

nanardon

Message:

Fix: avoid useless work when applying to unexported users

File:

• trunk/LATMOS-Accounts/lib/LATMOS/Accounts/Task/Employment.pm (modified) (1 diff)

trunk/LATMOS-Accounts/lib/LATMOS/Accounts/Task/Employment.pm

@@ -58 +58 @@
         my $employment = $res->{name};
         my $user = $res->{user};
+        exists($users{$user}) or next;
         # avoid undef:
         $users{$user} ||= '';
         if ($employment ne $users{$user}) {
-            $self->{_base}->log(LA_NOTICE, "Updating user $user to match employment `%s'", $employment || '');
             my $ouser = $self->{_base}->get_object('user', $user) or next;
 
+            $self->{_base}->log(LA_NOTICE, "Updating user $user to match employment `%s'", $employment || '');
             $ouser->applyCurrentEmployment;
             $self->{_base}->commit;