Changeset 2071

Timestamp:

08/25/17 08:21:05 (7 years ago)

Author:

nanardon

Message:

Allow to use a specific cracklib dictionnary

Location:

trunk/LATMOS-Accounts

Files:

• Changes (modified) (1 diff)
• lib/LATMOS/Accounts/Bases/Objects.pm (modified) (1 diff)
• lib/LATMOS/Accounts/Utils.pm (modified) (3 diffs)
• man/man5/latmos-accounts.ini.pod (modified) (1 diff)
• t/05_utils.t (modified) (2 diffs)

trunk/LATMOS-Accounts/Changes

@@ +1 @@
+5.2.19
+    - Allow to use a specific cracklib dictionnary 
+
 5.2.16
     - Allow to choose crypt() algorythm using crypt_method setting in

trunk/LATMOS-Accounts/lib/LATMOS/Accounts/Bases/Objects.pm

@@ -561 +561 @@
 sub check_password {
     my ( $self, $password ) = @_;
-    my $dictionary;
+    my $dictionary = $self->base->config('cracklib_dictionnary')
 
     if ($password !~ /^[[:ascii:]]*$/) {

trunk/LATMOS-Accounts/lib/LATMOS/Accounts/Utils.pm

@@ -324 +324 @@
 Use a set of syllables instead letter
 
+=item checkpassword
+
+A sub reference to check if generated password is valid
+
 =back
 
@@ -330 +334 @@
 sub genpassword {
     my (%options) = @_;
+
+    $options{checkpassword} ||= sub {
+        my ($cpass) = @_;
+        return fascist_check($pass) eq 'ok';
+    };
+
     my @non_alpha = (qw$; : / ! ( ) [ ] { } + = @ - " ' % * & . ? < >$, ',', '$');
     my @letters = ('a' .. 'z', 'A' .. 'Z', 0 .. 9);
@@ -366 +376 @@
 
         my $pass = join('', sort { rand() <=> rand() } @chars);
-        if (length($pass) >= 6 && fascist_check($pass) eq 'ok') {
+        if (length($pass) >= 6 && $options{checkpassword}->($pass)) {
             return $pass;
         }

trunk/LATMOS-Accounts/man/man5/latmos-accounts.ini.pod

@@ -57 +57 @@
 
 Can be specified per base.
+
+=head3 cracklib_dictionnary
+
+The path to a specific dictionnary formated for cracklib library
 
 =head2 [_defattr_] SECTION

trunk/LATMOS-Accounts/t/05_utils.t

@@ -1 +1 @@
 use strict;
 use warnings;
-use Test::More tests => 44;
+use Test::More tests => 46;
 use File::Temp qw(mkstemp);
 
@@ -77 +77 @@
 is(LATMOS::Accounts::Utils::buildLogin(sub { length($_[0]) > 9 }, 'TotoTataTiti'), 'tototatati', "buildLogin return 8 byte length login");
 
+ok(LATMOS::Accounts::Utils::genpassword(), "can generate a password");
+ok(LATMOS::Accounts::Utils::genpassword(
+        checkpassword => sub { 1 },
+    ), "can generate a password");
+
 my $clearpass = 'passwd';
 my $password = '';