Changeset 2194 for trunk/LATMOS-Accounts/lib/LATMOS/Accounts

Timestamp:

02/12/19 01:01:48 (5 years ago)

Author:

nanardon

Message:

Avoid useless commit() and computation at db load

File:

• trunk/LATMOS-Accounts/lib/LATMOS/Accounts/Bases/Sql.pm (modified) (3 diffs)

trunk/LATMOS-Accounts/lib/LATMOS/Accounts/Bases/Sql.pm

@@ -191 +191 @@
     );
 
+    my $change = 0;
+
     $self->temp_switch_unexported( sub {
 
-            my $setnodel  = $dbi->prepare('UPDATE objects SET nodelete     = true where name = ?');
-            my $setintern = $dbi->prepare('UPDATE objects SET internobject = true where name = ?');
+            my $setnodel  = $dbi->prepare('UPDATE objects SET nodelete     = true where name = ? and nodelete     = false');
+            my $setintern = $dbi->prepare('UPDATE objects SET internobject = true where name = ? and internobject = false');
 
             foreach (@objects) {
@@ -201 +203 @@
                     $self->create_object($_->{otype}, $_->{name}, %{$_->{attrs} || {}})
                         or warn sprintf("cannot create %s/%s\n", $_->{otype}, $_->{name});
-
+            $change += 1;
                 }
 
-                $setnodel->execute($_->{name});
-                $setintern->execute($_->{name}) if ($_->{intern});
+                $change +=  $setnodel->execute($_->{name});
+            $change +=  $setintern->execute($_->{name}) if ($_->{intern});
             }
 
     }, 1);
-    $self->commit;
+
+    if ($change > 0) {
+        $self->db->commit;
+    } else {
+       $self->db->rollback;
+    }
 
     return 1;
@@ -415 +422 @@
 
     # Let sync-manager update data in background
-
     $self->PopulateDynData unless($self->config('ASyncDynData'));