Changeset 420

Timestamp:

09/04/09 05:12:38 (15 years ago)

Author:

nanardon

Message:

• allow to manage CREATE/DELETE action in acls

Location:

LATMOS-Accounts

Files:

• lib/LATMOS/Accounts/Acls.pm (modified) (2 diffs)
• t/21_acls.t (modified) (2 diffs)
• testdata/acls1 (modified) (1 diff)

LATMOS-Accounts/lib/LATMOS/Accounts/Acls.pm

@@ -182 +182 @@
 sub match {
     my ($self, $obj, $attr, $perm, $who, $groups) = @_;
-    my $objtype = lc($obj->type); $attr = lc($attr);
+    my $objtype = ref $obj ? lc($obj->type) : $obj;
+    $attr = lc($attr);
     if (!($self->{obj} eq '*' || $self->{obj} eq $objtype)) {
         return
@@ -190 +191 @@
     foreach my $u (@{ $self->{users} }) {
         if (substr($u->{user}, 0, 1) eq '$') { # check attr content
-            my $attribute = substr($u->{user}, 1);
-            my $val = $obj->_get_c_field($attribute);
-            my @vals = ref $val ? (@{ $val }) : ($val);
-            return ($u->{$perm} || 0) if (grep { $_ eq $who } @vals);
+            if (ref $obj) {
+                my $attribute = substr($u->{user}, 1);
+                my $val = $obj->_get_c_field($attribute);
+                my @vals = ref $val ? (@{ $val }) : ($val);
+                return ($u->{$perm} || 0) if (grep { $_ eq $who } @vals);
+            }
         } elsif (substr($u->{user}, 0, 1) eq '%') { # group
             my $group = substr($u->{user}, 1);

LATMOS-Accounts/t/21_acls.t

@@ -1 +1 @@
 use strict;
 use warnings;
-use Test::More tests => 13;
+use Test::More tests => 14;
 
 use_ok('LATMOS::Accounts::Acls');
@@ -39 +39 @@
         $acls->check(fakeobject->new('group', 'group1'), 'uid', 'w',
             'user1', [ 'admin' ]), 1, "user can write group attribute");
+    is(
+        $acls->check('user', 'CREATE', 'w', 'user1', [ 'admin' ]), 1,
+            "user can create a new user");
 }
 

LATMOS-Accounts/testdata/acls1

@@ -3 +3 @@
 *.userPassword
     *: read,deny # the deny will mask the read
+
+user.CREATE
+    user1: write
 
 user.{sn,\