Changeset 88

Timestamp:

05/11/09 22:46:45 (15 years ago)

Author:

nanardon

Message:

• really improve memberUID laziness on change

File:

• LATMOS-Accounts/lib/LATMOS/Accounts/Bases/Sql/Group.pm (modified) (1 diff)

LATMOS-Accounts/lib/LATMOS/Accounts/Bases/Sql/Group.pm

@@ -94 +94 @@
         $attr =~ /^memberUID$/ and do {
             my $gid = $self->get_field('gid') or next;
-            if (join("\0", sort @{ $self->get_field('memberUID') }) eq
-                join("\0", sort @{ $data{$attr} || []})) {
-                next;
+            my %member;
+            foreach (@{ $self->get_field('memberUID') }) {
+                $member{$_}{c} = 1;
             }
-            $self->db->prepare_cached('delete from users_groups where gid = ?')
-                ->execute($gid);
             foreach (@{ $data{$attr} || []}) {
+                $member{$_}{n} = 1;
+            }
+
+            foreach (keys %member) {
+                $member{$_}{c} && $member{$_}{n} and next; # no change !
                 my $user = $self->base->get_object('user', $_) or next;
                 my $uid = $user->get_field('uid') or next;
-                my $sth = $self->db->prepare_cached(
-                    q{insert into users_groups (uid, gid) values (?,?)}
-                );
-                $sth->execute($uid, $gid);
+                if ($member{$_}{n}) {
+                    my $sth = $self->db->prepare_cached(
+                        q{insert into users_groups (uid, gid) values (?,?)}
+                    );
+                    $sth->execute($uid, $gid);
+                } elsif ($member{$_}{c}) {
+                    my $sth = $self->db->prepare_cached(
+                        q{delete from users_groups where uid = ? and gid = ?}
+                    );
+                    $sth->execute($uid, $gid);
+                } # else {} # can't happend
             }
             next;