Changeset 12352

Timestamp:

2020-01-29T13:24:59+01:00 (4 years ago)

Author:

dford

Message:

Update biogeochemical BDY code, and fix a couple of bugs in FABM coupling code. See Met Office utils ticket 305.

Location:

branches/UKMO/AMM15_v3_6_STABLE_package_collate/NEMOGCM/NEMO/TOP_SRC

Files:

• FABM/trcini_fabm.F90 (modified) (2 diffs)
• FABM/vertical_movement_fabm.F90 (modified) (1 diff)
• trcbdy.F90 (modified) (1 diff)

branches/UKMO/AMM15_v3_6_STABLE_package_collate/NEMOGCM/NEMO/TOP_SRC/FABM/trcini_fabm.F90

@@ -125 +125 @@
       jp_fabm_pgrow = fabm_diag_index( 'p_grow_sum_result' )
       jp_fabm_ploss = fabm_diag_index( 'p_loss_sum_result' )
-      
-      MLD_MAX(:,:)   = 0.0
-      PGROW_AVG(:,:) = 0.0
-      PLOSS_AVG(:,:) = 0.0
-      PHYT_AVG(:,:)  = 0.0
 
       IF (lwp) THEN
@@ -437 +432 @@
          ENDDO
       ENDIF
+      
+      ! Initialise variables required for Hemmings et al. (2008)
+      ! nitrogen balancing for chlorophyll data assimilation
+      MLD_MAX(:,:)   = 0.0
+      PGROW_AVG(:,:) = 0.0
+      PLOSS_AVG(:,:) = 0.0
+      PHYT_AVG(:,:)  = 0.0
 
    END SUBROUTINE trc_ini_fabm

branches/UKMO/AMM15_v3_6_STABLE_package_collate/NEMOGCM/NEMO/TOP_SRC/FABM/vertical_movement_fabm.F90

@@ -104 +104 @@
                   c_no(2:k_floor)=abs(w_if(2:k_floor,jn))*z2dt/ &
                                 ( 0.5_wp*(fse3t(ji,jj,2:k_floor) + &
-                                fse3t(ji,ji,1:k_floor-1)) )
+                                fse3t(ji,jj,1:k_floor-1)) )
                   cmax_no=MAXVAL(c_no(2:k_floor))
 

branches/UKMO/AMM15_v3_6_STABLE_package_collate/NEMOGCM/NEMO/TOP_SRC/trcbdy.F90

@@ -109 +109 @@
             ii = idx%nbi(ib,igrd)
             ij = idx%nbj(ib,igrd)
-            zwgt = idx%nbw(ib,igrd)
+            zwgt = idx%nbw(ib,igrd) * rdttrc(ik) / 86400.d0  ! damping with a timescale of day
             tra(ii,ij,ik,jn) = ( tra(ii,ij,ik,jn) + zwgt * ( ( dta%trc(ib,ik) * dta%rn_fac)  & 
                         &  - tra(ii,ij,ik,jn) ) ) * tmask(ii,ij,ik)
          END DO
       END DO 
+! tra is overwritten at the boundary so damping doesn't work here - need neumann in addition
+! to duplicate the internal value at the boundary
+       CALL bdy_trc_nmn( jn,  idx, dta, kt )
+
+
       !
       IF( kt .eq. nit000 ) CLOSE( unit = 102 )