Changeset 8862 for branches/2015/nemo_v3_6_STABLE/NEMOGCM/TOOLS/SIREN/src/iom_cdf.f90

Timestamp:

2017-11-30T16:58:49+01:00 (6 years ago)

Author:

jpaul

Message:

Bugs fix: see tickets #1989

File:

• branches/2015/nemo_v3_6_STABLE/NEMOGCM/TOOLS/SIREN/src/iom_cdf.f90 (modified) (25 diffs)

branches/2015/nemo_v3_6_STABLE/NEMOGCM/TOOLS/SIREN/src/iom_cdf.f90

@@ -316 +316 @@
    !> @author J.Paul
    !> @date November, 2013 - Initial Version
+   !> @date October, 2016
+   !> - define cdf4 as cdf.
    !
    !> @param[inout] td_file   file structure
@@ -340 +342 @@
             td_file%c_type='cdf'
          CASE(nf90_format_netcdf4, nf90_format_netcdf4_classic)
+            !td_file%c_type='cdf4'
             td_file%c_type='cdf'
-            !td_file%c_type='cdf4'
       END SELECT
       CALL logger_debug("IOM CDF GET INFO: type "//TRIM(td_file%c_type)) 
@@ -353 +355 @@
    !> reorder dimension to ('x', 'y', 'z', 't').
    !> The dimension structure inside file structure is then completed.
-   !
-   !> @author J.Paul
-   !> @date November, 2013 - Initial Version
-   !
+   !>
+   !> @author J.Paul
+   !> @date November, 2013 - Initial Version
+   !> @date October, 2016
+   !> - check unknown dimension
+   !>
    !> @param[inout] td_file   file structure
    !-------------------------------------------------------------------
@@ -377 +381 @@
 
       IF( td_file%i_ndim > 0 )THEN
+
          ii=1
          DO ji = 1, td_file%i_ndim
             ! read dimension information
             tl_dim=iom_cdf_read_dim( td_file, ji)
-            IF( .NOT. dim_is_dummy(tl_dim) )THEN
+            ! sname == 'u' if dimension is unknown (not to be used)
+            IF( TRIM(tl_dim%c_sname) /= 'u' )THEN
                IF( ii > ip_maxdim )THEN
                   CALL logger_fatal("IOM CDF OPEN: too much dimension "//&
-                  & "to be read. you should remove dummy dimension using "//&
+                  & "to be read. you could choose dimension to be used. see "//&
                   & " configuration file")
                ENDIF
@@ -397 +403 @@
             &  " IOM CDF GET FILE DIM: there is no unlimited dimension in file "//&
             &  TRIM(td_file%c_name))
-         ELSE
-            td_file%t_dim( td_file%i_uldid )%l_uld=.TRUE.
+         !ELSE
+         !   td_file%t_dim( td_file%i_uldid )%l_uld=.TRUE.
          ENDIF
 
@@ -468 +474 @@
    !> The variable structure inside file structure is then completed.
    !> @note variable value are not read !
-   !
+   !>
    !> @author J.Paul
    !> @date November, 2013 - Initial Version
@@ -475 +481 @@
    !> @date January, 2016
    !> - increment n3d for 4D variable
-   !
+   !> @date October, 2016
+   !> - check variable to be used (variable's dimension allowed and variable
+   !> not "dummy")
+   !>
    !> @param[inout] td_file   file structure
    !-------------------------------------------------------------------
@@ -503 +512 @@
          il_nvar=td_file%i_nvar
          ALLOCATE(tl_var(il_nvar))
-         ii=0
          DO ji = 1, il_nvar
            ! read variable information
            tl_var(ji)=iom_cdf__read_var_meta( td_file, ji) 
-           IF( .NOT. var_is_dummy(tl_var(ji)) )THEN
-              ii=ii+1
-           ENDIF
          ENDDO
 
          ! update number of variable used
-         td_file%i_nvar=ii
+         td_file%i_nvar=COUNT(tl_var(:)%l_use)
 
          ALLOCATE(td_file%t_var(td_file%i_nvar))
@@ -519 +524 @@
          ii=0
          DO ji = 1, il_nvar
-            IF( .NOT. var_is_dummy(tl_var(ji)) )THEN
+            IF( tl_var(ji)%l_use )THEN
                ii=ii+1
                td_file%t_var(ii)=var_copy(tl_var(ji))
@@ -554 +559 @@
                      td_file%i_timeid=ji
                   ELSE
+                     IF( td_file%i_timeid /= ji )THEN
+                        CALL logger_warn("IOM CDF GET FILE VAR: find more "//&
+                        &                 "than one time variable in file "//&
+                        &                 TRIM(td_file%c_name)//". see "//&
+                        &                 "dummy.cfg configuration file to"//&
+                        &                 " not used dummy variables.")
+                     ENDIF
                      il_attid=0
                      IF( ASSOCIATED(td_file%t_var(ii)%t_att) )THEN
@@ -560 +572 @@
                      IF( il_attid /= 0 )THEN
                         td_file%i_timeid=ji
-                     !ELSE
-                     !   CALL logger_error("IOM CDF GET FILE VAR: find more "//&
-                     !   &                 "than one time variable in file "//&
-                     !   &                 TRIM(td_file%c_name) )
                      ENDIF
                   ENDIF
@@ -654 +662 @@
          &  " IOM CDF READ DIM: no id associated to file "//TRIM(td_file%c_name))
 
-      ELSE      
+      ELSE
 
          CALL logger_trace( &
@@ -725 +733 @@
    !> @author J.Paul
    !> @date November, 2013 - Initial Version
+   !> @date November 2017
+   !> - check if cl_value is not bug 
    !
    !> @param[in] td_file   file structure
@@ -795 +805 @@
 
             CASE(NF90_CHAR)
+               CALL logger_debug( " IOM CDF READ ATT: get NF90_CHAR ")
 
                ! check string lengths
@@ -811 +822 @@
                   CALL iom_cdf__check(il_status,"IOM CDF READ ATT: ")
 
+                  ! check cl_value
+                  IF( LLT(cl_value,'') ) cl_value = ''
                   iom_cdf__read_att_name=att_init(cl_name, cl_value)
 
@@ -816 +829 @@
          
             CASE(NF90_BYTE)
+               CALL logger_debug( " IOM CDF READ ATT: get NF90_BYTE ")
 
                ALLOCATE( bl_value( il_len), &
@@ -839 +853 @@
 
             CASE(NF90_SHORT)
+               CALL logger_debug( " IOM CDF READ ATT: get NF90_SHORT ")
 
                ALLOCATE( sl_value( il_len), &
@@ -863 +878 @@
 
             CASE(NF90_INT)
+               CALL logger_debug( " IOM CDF READ ATT: get NF90_INT ")
 
                ALLOCATE( il_value( il_len), &
@@ -886 +902 @@
 
             CASE(NF90_FLOAT)
+               CALL logger_debug( " IOM CDF READ ATT: get NF90_FLOAT ")
 
                ALLOCATE( fl_value( il_len), &
@@ -910 +927 @@
 
             CASE(NF90_DOUBLE)
+               CALL logger_debug( " IOM CDF READ ATT: get NF90_DOUBLE ")
 
                ALLOCATE( dl_value( il_len), &
@@ -1415 +1433 @@
          ENDDO
 
+         !! check if variable is dummy
+         IF( var_is_dummy(iom_cdf__read_var_meta) )THEN
+            iom_cdf__read_var_meta%l_use=.FALSE.
+         ENDIF
+
+         !! check if all dimensions are allowed
+         DO ji=1,il_ndim
+            IF( ALL(td_file%t_dim(:)%i_id /= il_dimid(ji)) )THEN
+               iom_cdf__read_var_meta%l_use=.FALSE.
+            ENDIF
+         ENDDO
+
          ! clean
          CALL dim_clean(tl_dim(:))
@@ -1486 +1516 @@
       ELSE IF( id_ndim > 0 )THEN
 
-
          ii=1
          DO ji = 1, id_ndim
 
-            !!! check no dummy dimension to be used
+            ! check if dimension to be used, is allowed
             IF( ANY(td_file%t_dim(:)%i_id == id_dimid(ji)) )THEN
                IF( ii > ip_maxdim )THEN
@@ -1506 +1535 @@
                tl_dim(ii) = dim_init( td_file%t_dim(il_xyzt2(ii))%c_name, &
                &                      td_file%t_dim(il_xyzt2(ii))%i_len )
-            
+
                ii=ii+1
             ELSE
@@ -2082 +2111 @@
                   & 'gcost','gcosu','gcosv','gcosf', &
                   & 'gsint','gsinu','gsinv','gsinf', &
-                  & 'mbathy','misf','isf_draft',     &
+                  & 'mbathy','misf','isf_draft','isfdraft',     &
                   & 'hbatt','hbatu','hbatv','hbatf', &
                   & 'gsigt','gsigu','gsigv','gsigf', &
@@ -2191 +2220 @@
          CALL iom_cdf__check(il_status,"IOM CDF WRITE VAR DEF: ")
       ENDIF
+      CALL logger_debug("IOM CDF WRITE VAR DEF: type = "//TRIM(fct_str(tl_var%i_type)))
 
       ! remove unuseful attribute