Form 68 (in 2017WP/ENHANCE-17_Gurvan_MCO)

Saved Values

in subcontext 'abstract'

implementation: 'Describe flow chart of the changes in the code.\n\nList the .F90 files and modules to be changed.\n\nDetailed list of new variables (including namelists) to be defined.\nGive for each the chosen name (following coding rules) and definition. Starting point TRUNK, revision 8218 STEP 1 - introduce changes in the ocean (OPA_SRC) • iom.F90 defined ncolmco axis from 0 to jpl (i.e. ocean + jpl ice categories) • step.F90, step_oce.F90 : add tramco.F90 • phycst.F90 : unchanged (keep rt0_ice & rt0_snw to 273.15 (273.16 in Antoine's code) • sbc_oce.F90 : - add ln_ice_mco in namsbc (Its usage has to be changed ) <<<==== - add a " USE par_ice, ONLY: jpl " this will not work if key_lim3 not defined <<<==== - add taum_b (to be used in zdftke.F90) - defined all MCO variables in memory but using jpl !!! Pb here <<<==== - NB: name of variables end with _col BETTER to use _mco !!! <<<==== • step.F90 & step_c1d.F90 : add optional call to tra_mco - step_C1d issue with a call to dos with potential density: to be solved with changes in PISCES <<<==== - in both cases, simplified the logical test " IF( nn_mco > 0 .OR. ln_flxcol ) " using a local logical set one for all <<<==== • tranpc.F90 : replace the existing trunk routine by Antoine's one that correct bugs and has been extensively validated • traqsr.F90 : introduce required argument to tra_qsr routine and adapt Antoine changes to the new routine • trasbc.F90 : - split in 3 parts: trasbc.F90, trarnf.F90 and traisf.F90 for ocean surface (ocean/air-ice), runoffs (ocean/land) and ice-shelf (top boundary condition in ice-shelf cavities), rep. - in the resulting trasbc.F90 introduce required argument to tra_sbc routine and adapt Antoine changes to the new routine - tra_rnf and tra_isf are just the ext ration of tra_sbc routine NB1: all j-do loop have been changed from 2, jpj to 2, jpjm1 NB2 : we keep the setting to zero of heat salt content now field at 1st time step, which may avoid NaN in the mpp allows • trazdf.F90 and trazdf_imp.F90 : add kz in the input argument • zdfini.F90 : add a case 2 fort the horizontal shape of the background (reduce background in both Equatorial strip and high latitudes) • zdftke.F90 : adapt Antoine's version to the new code (mostly the suppression of domzgr_substitute.h90) ===>>> code is compiling. (save in "MY_SRC - compile OK - dyn part" test with GYRE_PISCES (without key_top) OK songs reasonable results ' by gm2017-07-07T16:59:26+02:00
manual: 'Using part 1 and 2, define the summary of changes to be done in the NEMO reference manual (tex files), and in the content of web pages.' by gm2017-07-05T10:11:13+02:00
description: 'Describe the goal of development, and the methodology.\n\nAdd reference documents or publications if relevant. NB: the current version, based on Barthélemy et al (1016) paper, has been developed in fixed volume only (linear free surface). The adaptation to non-linear free surface is possible, but will require additional developments. In particular, we will have to introduce a thickness of the first ocean level that depends on the ice categories in order to account for the changes in surface salinity below each ice category (change in volume not in the concentration/dilution term as in fixed volume). Furthermore, it will be of great interest to add an option of two ocean columns (one for leads and one for sea-ice) for Kz computation only. The area averaged Kz will be used on T, S, u and v mixing. ' by gm2017-07-05T10:11:13+02:00

Change History

Changed on 2017-07-07T16:59:26+02:00 by gm:

  • implementation changed from
    Describe flow chart of the changes in the code.\n\nList the .F90 files and modules to be changed.\n\nDetailed list of new variables (including namelists) to be defined.\nGive for each the chosen name (following coding rules) and definition. Starting point TRUNK, revision 8218 STEP 1 - introduce changes in the ocean (OPA_SRC) • iom.F90 defined ncolmco axis from 0 to jpl (i.e. ocean + jpl ice categories) • step.F90, step_oce.F90 : add tramco.F90 • phycst.F90 : unchanged (keep rt0_ice & rt0_snw to 273.15 (273.16 in Antoine's code) • sbc_oce.F90 : - add ln_ice_mco in namsbc (Its usage has to be changed ) <<<==== - add a " USE par_ice, ONLY: jpl " this will not work if key_lim3 not defined <<<==== - add taum_b (to be used in zdftke.F90) - defined all MCO variables in memory but using jpl !!! Pb here <<<==== - NB: name of variables end with _col BETTER to use _mco !!! <<<==== • step.F90 & step_c1d.F90 : add optional call to tra_mco - step_C1d issue with a call to dos with potential density: to be solved with changes in PISCES <<<==== - in both cases, simplified the logical test " IF( nn_mco > 0 .OR. ln_flxcol ) " using a local logical set one for all <<<==== • tranpc.F90 : replace the existing trunk routine by Antoine's one that correct bugs and has been extensively validated • traqsr.F90 : introduce required argument to tra_qsr routine and adapt Antoine changes to the new routine • trasbc.F90 : - split in 3 parts: trasbc.F90, trarnf.F90 and traisf.F90 for ocean surface (ocean/air-ice), runoffs (ocean/land) and ice-shelf (top boundary condition in ice-shelf cavities), rep. - in the resulting trasbc.F90 introduce required argument to tra_sbc routine and adapt Antoine changes to the new routine - tra_rnf and tra_isf are just the ext ration of tra_sbc routine NB1: all j-do loop have been changed from 2, jpj to 2, jpjm1 NB2 : we keep the setting to zero of heat salt content now field at 1st time step, which may avoid NaN in the mpp allows • trazdf.F90 and trazdf_imp.F90 : add kz in the input argument
    to
    Describe flow chart of the changes in the code.\n\nList the .F90 files and modules to be changed.\n\nDetailed list of new variables (including namelists) to be defined.\nGive for each the chosen name (following coding rules) and definition. Starting point TRUNK, revision 8218 STEP 1 - introduce changes in the ocean (OPA_SRC) • iom.F90 defined ncolmco axis from 0 to jpl (i.e. ocean + jpl ice categories) • step.F90, step_oce.F90 : add tramco.F90 • phycst.F90 : unchanged (keep rt0_ice & rt0_snw to 273.15 (273.16 in Antoine's code) • sbc_oce.F90 : - add ln_ice_mco in namsbc (Its usage has to be changed ) <<<==== - add a " USE par_ice, ONLY: jpl " this will not work if key_lim3 not defined <<<==== - add taum_b (to be used in zdftke.F90) - defined all MCO variables in memory but using jpl !!! Pb here <<<==== - NB: name of variables end with _col BETTER to use _mco !!! <<<==== • step.F90 & step_c1d.F90 : add optional call to tra_mco - step_C1d issue with a call to dos with potential density: to be solved with changes in PISCES <<<==== - in both cases, simplified the logical test " IF( nn_mco > 0 .OR. ln_flxcol ) " using a local logical set one for all <<<==== • tranpc.F90 : replace the existing trunk routine by Antoine's one that correct bugs and has been extensively validated • traqsr.F90 : introduce required argument to tra_qsr routine and adapt Antoine changes to the new routine • trasbc.F90 : - split in 3 parts: trasbc.F90, trarnf.F90 and traisf.F90 for ocean surface (ocean/air-ice), runoffs (ocean/land) and ice-shelf (top boundary condition in ice-shelf cavities), rep. - in the resulting trasbc.F90 introduce required argument to tra_sbc routine and adapt Antoine changes to the new routine - tra_rnf and tra_isf are just the ext ration of tra_sbc routine NB1: all j-do loop have been changed from 2, jpj to 2, jpjm1 NB2 : we keep the setting to zero of heat salt content now field at 1st time step, which may avoid NaN in the mpp allows • trazdf.F90 and trazdf_imp.F90 : add kz in the input argument • zdfini.F90 : add a case 2 fort the horizontal shape of the background (reduce background in both Equatorial strip and high latitudes) • zdftke.F90 : adapt Antoine's version to the new code (mostly the suppression of domzgr_substitute.h90) ===>>> code is compiling. (save in "MY_SRC - compile OK - dyn part" test with GYRE_PISCES (without key_top) OK songs reasonable results

Changed on 2017-07-05T16:18:22+02:00 by gm:

Changed on 2017-07-05T16:18:22+02:00 by gm:

  • implementation changed from
    Describe flow chart of the changes in the code.\n\nList the .F90 files and modules to be changed.\n\nDetailed list of new variables (including namelists) to be defined.\nGive for each the chosen name (following coding rules) and definition. Starting point TRUNK, revision 8218 STEP 1 - introduce changes in the ocean (OPA_SRC) • iom.F90 defined ncolmco axis from 0 to jpl (i.e. ocean + jpl ice categories) • step.F90, step_oce.F90 : add tramco.F90 • phycst.F90 : unchanged (keep rt0_ice & rt0_snw to 273.15 (273.16 in Antoine's code) • sbc_oce.F90 : - add ln_ice_mco in namsbc (Its usage has to be changed ) <<<==== - add a " USE par_ice, ONLY: jpl " this will not work if key_lim3 not defined <<<==== - add taum_b (to be used in zdftke.F90) - defined all MCO variables in memory but using jpl !!! Pb here <<<==== - NB: name of variables end with _col BETTER to use _mco !!! <<<==== • step.F90 & step_c1d.F90 : add optional call to tra_mco - step_C1d issue with a call to dos with potential density: to be solved with changes in PISCES <<<==== - in both cases, simplified the logical test " IF( nn_mco > 0 .OR. ln_flxcol ) " using a local logical set one for all <<<==== • tranpc.F90 : replace the existing trunk routine by Antoine's one that correct bugs and has been extensively validated • traqsr.F90 : introduce required argument to tra_qsr routine and adapt Antoine changes to the new routine • trasbc.F90 : - split in 3 parts: trasbc.F90, trarnf.F90 and traisf.F90 for ocean surface (ocean/air-ice), runoffs (ocean/land) and ice-shelf (top boundary condition in ice-shelf cavities), rep. - in the resulting trasbc.F90 introduce required argument to tra_sbc routine and adapt Antoine changes to the new routine - tra_rnf and tra_isf are just the ext ration of tra_sbc routine
    to
    Describe flow chart of the changes in the code.\n\nList the .F90 files and modules to be changed.\n\nDetailed list of new variables (including namelists) to be defined.\nGive for each the chosen name (following coding rules) and definition. Starting point TRUNK, revision 8218 STEP 1 - introduce changes in the ocean (OPA_SRC) • iom.F90 defined ncolmco axis from 0 to jpl (i.e. ocean + jpl ice categories) • step.F90, step_oce.F90 : add tramco.F90 • phycst.F90 : unchanged (keep rt0_ice & rt0_snw to 273.15 (273.16 in Antoine's code) • sbc_oce.F90 : - add ln_ice_mco in namsbc (Its usage has to be changed ) <<<==== - add a " USE par_ice, ONLY: jpl " this will not work if key_lim3 not defined <<<==== - add taum_b (to be used in zdftke.F90) - defined all MCO variables in memory but using jpl !!! Pb here <<<==== - NB: name of variables end with _col BETTER to use _mco !!! <<<==== • step.F90 & step_c1d.F90 : add optional call to tra_mco - step_C1d issue with a call to dos with potential density: to be solved with changes in PISCES <<<==== - in both cases, simplified the logical test " IF( nn_mco > 0 .OR. ln_flxcol ) " using a local logical set one for all <<<==== • tranpc.F90 : replace the existing trunk routine by Antoine's one that correct bugs and has been extensively validated • traqsr.F90 : introduce required argument to tra_qsr routine and adapt Antoine changes to the new routine • trasbc.F90 : - split in 3 parts: trasbc.F90, trarnf.F90 and traisf.F90 for ocean surface (ocean/air-ice), runoffs (ocean/land) and ice-shelf (top boundary condition in ice-shelf cavities), rep. - in the resulting trasbc.F90 introduce required argument to tra_sbc routine and adapt Antoine changes to the new routine - tra_rnf and tra_isf are just the ext ration of tra_sbc routine NB1: all j-do loop have been changed from 2, jpj to 2, jpjm1 NB2 : we keep the setting to zero of heat salt content now field at 1st time step, which may avoid NaN in the mpp allows • trazdf.F90 and trazdf_imp.F90 : add kz in the input argument

Changed on 2017-07-05T12:15:13+02:00 by gm:

Changed on 2017-07-05T12:15:13+02:00 by gm:

  • implementation changed from
    Describe flow chart of the changes in the code.\n\nList the .F90 files and modules to be changed.\n\nDetailed list of new variables (including namelists) to be defined.\nGive for each the chosen name (following coding rules) and definition. Starting point TRUNK, revision 8218 STEP 1 - introduce changes in the ocean (OPA_SRC) • iom.F90 defined ncolmco axis from 0 to jpl (i.e. ocean + jpl ice categories) • step.F90, step_oce.F90 : add tramco.F90 • phycst.F90 : unchanged (keep rt0_ice & rt0_snw to 273.15 (273.16 in Antoine's code) • sbc_oce.F90 : - add ln_ice_mco in namsbc (Its usage has to be changed ) <<<==== - add a " USE par_ice, ONLY: jpl " this will not work if key_lim3 not defined <<<==== - add taum_b (to be used in zdftke.F90) - defined all MCO variables in memory but using jpl !!! Pb here <<<==== - NB: name of variables end with _col BETTER to use _mco !!! <<<==== • step.F90 & step_c1d.F90 : add optional call to tra_mco - step_C1d issue with a call to dos with potential density: to be solved with changes in PISCES <<<==== - in both cases, simplified the logical test " IF( nn_mco > 0 .OR. ln_flxcol ) " using a local logical set one for all <<<==== • traqsr.F90 : introduce required argument to tea_qsr routine and adapt Antoine changes to the new routine
    to
    Describe flow chart of the changes in the code.\n\nList the .F90 files and modules to be changed.\n\nDetailed list of new variables (including namelists) to be defined.\nGive for each the chosen name (following coding rules) and definition. Starting point TRUNK, revision 8218 STEP 1 - introduce changes in the ocean (OPA_SRC) • iom.F90 defined ncolmco axis from 0 to jpl (i.e. ocean + jpl ice categories) • step.F90, step_oce.F90 : add tramco.F90 • phycst.F90 : unchanged (keep rt0_ice & rt0_snw to 273.15 (273.16 in Antoine's code) • sbc_oce.F90 : - add ln_ice_mco in namsbc (Its usage has to be changed ) <<<==== - add a " USE par_ice, ONLY: jpl " this will not work if key_lim3 not defined <<<==== - add taum_b (to be used in zdftke.F90) - defined all MCO variables in memory but using jpl !!! Pb here <<<==== - NB: name of variables end with _col BETTER to use _mco !!! <<<==== • step.F90 & step_c1d.F90 : add optional call to tra_mco - step_C1d issue with a call to dos with potential density: to be solved with changes in PISCES <<<==== - in both cases, simplified the logical test " IF( nn_mco > 0 .OR. ln_flxcol ) " using a local logical set one for all <<<==== • tranpc.F90 : replace the existing trunk routine by Antoine's one that correct bugs and has been extensively validated • traqsr.F90 : introduce required argument to tra_qsr routine and adapt Antoine changes to the new routine • trasbc.F90 : - split in 3 parts: trasbc.F90, trarnf.F90 and traisf.F90 for ocean surface (ocean/air-ice), runoffs (ocean/land) and ice-shelf (top boundary condition in ice-shelf cavities), rep. - in the resulting trasbc.F90 introduce required argument to tra_sbc routine and adapt Antoine changes to the new routine - tra_rnf and tra_isf are just the ext ration of tra_sbc routine

Changed on 2017-07-05T11:33:27+02:00 by gm:

Changed on 2017-07-05T11:33:27+02:00 by gm:

  • implementation changed from
    Describe flow chart of the changes in the code.\n\nList the .F90 files and modules to be changed.\n\nDetailed list of new variables (including namelists) to be defined.\nGive for each the chosen name (following coding rules) and definition. Starting point TRUNK, revision 8218 STEP 1 - introduce changes in the ocean (OPA_SRC) • iom.F90 defined ncolmco axis from 0 to jpl (i.e. ocean + jpl ice categories) • step.F90, step_oce.F90 : add tramco.F90 • phycst.F90 : unchanged (keep rt0_ice & rt0_snw to 273.15 (273.16 in Antoine's code) • sbc_oce.F90 : - add ln_ice_mco in namsbc (Its usage has to be changed ) <<<==== - add a " USE par_ice, ONLY: jpl " this will not work if key_lim3 not defined <<<==== - add taum_b (to be used in zdftke.F90) - defined all MCO variables in memory but using jpl !!! Pb here <<<==== - NB: name of variables end with _col BETTER to use _mco !!! <<<==== • step.F90 & step_c1d.F90 : add optional call to tra_mco - step_C1d issue with a call to dos with potential density: to be solved with changes in PISCES <<<==== - in both cases, simplified the logical test " IF( nn_mco > 0 .OR. ln_flxcol ) " using a local logical set one for all <<<====
    to
    Describe flow chart of the changes in the code.\n\nList the .F90 files and modules to be changed.\n\nDetailed list of new variables (including namelists) to be defined.\nGive for each the chosen name (following coding rules) and definition. Starting point TRUNK, revision 8218 STEP 1 - introduce changes in the ocean (OPA_SRC) • iom.F90 defined ncolmco axis from 0 to jpl (i.e. ocean + jpl ice categories) • step.F90, step_oce.F90 : add tramco.F90 • phycst.F90 : unchanged (keep rt0_ice & rt0_snw to 273.15 (273.16 in Antoine's code) • sbc_oce.F90 : - add ln_ice_mco in namsbc (Its usage has to be changed ) <<<==== - add a " USE par_ice, ONLY: jpl " this will not work if key_lim3 not defined <<<==== - add taum_b (to be used in zdftke.F90) - defined all MCO variables in memory but using jpl !!! Pb here <<<==== - NB: name of variables end with _col BETTER to use _mco !!! <<<==== • step.F90 & step_c1d.F90 : add optional call to tra_mco - step_C1d issue with a call to dos with potential density: to be solved with changes in PISCES <<<==== - in both cases, simplified the logical test " IF( nn_mco > 0 .OR. ln_flxcol ) " using a local logical set one for all <<<==== • traqsr.F90 : introduce required argument to tea_qsr routine and adapt Antoine changes to the new routine

Changed on 2017-07-05T10:11:13+02:00 by gm: