Custom Query (2350 matches)

Filters
 
Or
 
  
 
Columns

Show under each result:


Results (16 - 18 of 2350)

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16
Ticket Resolution Summary Owner Reporter
#2519 fixed User defined straight open boundary segments and halo size does not work systeam jchanut
Description

Context

User defined straight open boundary segments (nambdy_seg block) is broken with recent halo size change

Analysis

Boundary indexes in that case should be shifted by nn_hls Default definition (on domain edges) still rely on global sizes (with variable halo)

Fix

#2518 fixed uninitialised mean sst and sss variables when using SAS and simplified ice restart gsamson gsamson
Description

Context & Analysis

In the particular case where SAS is used with a simplified ice restart (ln_iceini = .true. and nn_iceini_file = 1), sst_m and sss_m needed by ice_istate are yet not initialised. Same problem with the trunk.

Fix

initialise sst_m and sss_m in ice_state_init or sbc_ssm_init before calling ice_istate

#2517 fixed Activation of option to use ice restart file for initial ice conditions when ln_rstart = .false. acc acc
Description

Context

The ice initialisation options includes a nn_iceini_file = 2 option which is meant to allow ice initial conditions to be read from a restart file (even when ln_rstart is false) but this option is not working in v4.0.3. The option is not present in the trunk version.

Analysis

The relevant code in icestp.F90 is:

      IF ( ln_rstart .OR. nn_iceini_file == 2 ) THEN 
         CALL ice_rst_read                      ! start from a restart file
      ELSE
         CALL ice_istate_init
         CALL ice_istate( nit000 )              ! start from rest or read a file
      ENDIF

but this won't work because nn_iceini_file isn't set until ice_istate_init, so this needs to be:

      CALL ice_istate_init
      IF ( ln_rstart .OR. nn_iceini_file == 2 ) THEN
         CALL ice_rst_read                      ! start from a restart file
      ELSE
         CALL ice_istate( nit000 )              ! start from rest or read a file
      ENDIF

Recommendation

In 4.0-HEAD, Make the simple change above and there is also an opportunity to tidy code inside icerst.F90 to remove a (now) redundant call to ice_istate_init.

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16
Note: See TracQuery for help on using queries.