New URL for NEMO forge!   http://forge.nemo-ocean.eu

Since March 2022 along with NEMO 4.2 release, the code development moved to a self-hosted GitLab.
This present forge is now archived and remained online for history.
Custom Query – NEMO

Custom Query (2547 matches)

Filters
 
Or
 
  
 
Columns

Show under each result:


Results (19 - 21 of 2547)

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17
Ticket Resolution Summary Owner Reporter
#2719 fixed Compilation error with TOP and AGRIF systeam jchanut
Description

Context

Andrea Gierisch reported issues when compiling TOP with key_agrif defined in 4.0.6 version. None of AGRIFed reference configurations does indeed use TOP (note that this situation has changed in the trunk, since AGRIF_DEMO does now embark a passive tracer).

Analysis

After Andrew's investigations, a couple of missing modules need to be used in PISCES which precludes from undefined variables. It seems that these undefined variables were properly tracked by the compiler without agrif thanks to an other level of used statement. That's a bit unclear though.

#2718 fixed Ice volume not correctly accounted for in the freshwater budget control option 2 (nn_fwb=2) systeam cdllod
Description

Context

In forced ocean mode, freshwater budget control is generally used to avoid a drift of the mean ocean salinity and mean sea level. This control is done in sbcfwb.F90. There are three available options (namelist parameter nn_fwb = 1, 2 or 3). The bug relates to option 2, where a correction to surface freshwater fluxes is calculated based on the net freshwater imbalance of the previous year.

Analysis

The imbalance is calculated at the end of the year as the global mean ssh plus the volume of sea ice. This imbalance should be zero in the initial state; that is, the initial ssh should be reduced to offset the initial volume of sea ice. This is currently the case if sea ice is fully embedded, thanks to lines 380-383 of the iceistate.F90 routine:

      IF( ln_ice_embd ) THEN            ! embedded sea-ice: deplete the initial ssh below sea-ice area
         !
         sshn(:,:) = sshn(:,:) - snwice_mass(:,:) * r1_rau0
         sshb(:,:) = sshb(:,:) - snwice_mass(:,:) * r1_rau0

However it is not the case if ice is not fully embedded. This leads to incorrect freshwater budget control and sea level drop in forced ORCA simulations that use nn_fwb = 2 and ln_ice_embd = false (which are default namelist parameters).

Fix

We propose to replace line 424 of the current (rev 15226) iceistate.F90 routine by the following:

      ELSE ! case ice is not fully embedded (this is needed to ensure correct freshwater budget control)
         zsshcor = glob_sum( 'iceistate', e1e2t(:,:) * snwice_mass(:,:) * r1_rau0 ) / glob_sum( 'iceistate', e1e2t(:,:) * tmask(:,:,1) )
         sshn(:,:) = sshn(:,:) - zsshcor
         sshb(:,:) = sshb(:,:) - zsshcor
      ENDIF

and to replace line 94 by:

      REAL(wp) ::   ztmelts, zsshcor

This will ensure that the volume of sea ice is correctly accounted for in the freshwater budget control (option 2). A three-year test simulation with this fix suggests it is working.

#2717 fixed Missing call to asm_bkg_write (trunk version) systeam timgraham
Description

Context

Somewhere in the development of NEMO4.0 the call to asm_bkg_wri has been removed from step. This means that the assim_background_Jb file is not written out when nitbkg is anything other than zero (in the case where it's zero there is a call from asm_init).

Fix

Reinstate "call asm_bkg_wri(kt)" in step.F90.

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17
Note: See TracQuery for help on using queries.