Custom Query (2547 matches)
Results (25 - 27 of 2547)
Ticket | Resolution | Summary | Owner | Reporter |
---|---|---|---|---|
#2710 | fixed | Sign error in lid melting code in topographic melt pond scheme | systeam | dlivings |
Description |
There is a sign error in the lid melting code in the topographic melt pond scheme in SI3. In the current version of NEMO/trunk/src/ICE/icethd_pnd.F90 (last changed at [14997]) the error is in line 664. This currently reads
but should be
(compare line 597). In the code as currently written, zdvice is always negative or zero, with the result that the test at line 666 always fails and the code that transfers volume from the lid to the pond is never executed. I've confirmed this by adding a statement that writes a log message the first time this piece of code is executed. |
|||
#2706 | fixed | ISF: bug in option cn_gammablk=vel_stab | systeam | clem |
Description |
For ISF when using option cn_gammablk=vel_stab, one must use the variable qoce in the subroutine isfcav_gammats but it is only calculated afterwards in isfcav_mlt. So, one must initialize qoce before its use in isfcav_gammats. In addition the initialization of qoce_b is probablement not the right one. It is written as the sensible flux while it should be the latent flux (see isfcav_mlt routine). Fix: change this line: IF (TRIM(cn_gammablk) == 'vel_stab' ) zqoce_b (:,:) = ptsc(:,:,jp_tem) * rho0_rcp ! last time step total heat fluxes (to speed up convergence) by this one: IF ( TRIM(cn_gammablk) == 'vel_stab' ) THEN zqoce(:,:) = -pqfwf(:,:) * rLfusisf ! zqh_b(:,:) = ptsc(:,:,jp_tem) * rho0_rcp ! last time step total heat fluxes (to speed up convergence) ENDIF And make the convergence criterion on qoce+qhc qnd not only qoce: zerr = MAXVAL(ABS(zqhc(:,:)+zqoce(:,:) - zqh_b(:,:))) I'll do the changes and commit them because this routine just does not pass debug right now but it needs to be checked out by people who know (I guess Pierre) |
|||
#2705 | invalid | IOM-01_dcarneir_ASM_SI3 | dcarneir | dcarneir |