Opened 8 years ago

Closed 8 years ago

#1036 closed Defect (fixed)

neptune effect need some reconding

Reported by: poddo Owned by: acc
Priority: low Milestone:
Component: OCE Version: release-3.4
Severity: Keywords:
Cc:

Description

Looking at the neptune effect rotuine I noticed that even if I do not use the neptune effect parameterizzation in the routine dyn_nept_init a lot of computations are done, in addition there is some memory allocation (not needed if neptune is not used), and in the standard output confusing messages are printed:
"dyn_nept_init : Simplified Neptune module enabled".
I think that the *init should read only the namelist and make some checks if necessary, allocations and computations should be somewhere else in the code (like all the other module we have in the code). I've seen that this routine is the same in the new release.

Commit History (2)

ChangesetAuthorTimeChangeLog
3726acc2012-12-10T11:37:43+01:00

Bugfix #1036 (repeated on the trunk). Tidy up dyn_nept_init to avoid unnecessary allocations and remove misleading output text

3723acc2012-12-06T17:12:04+01:00

Bugfix #1036. Tidy up dyn_nept_init to avoid unnecessary allocations and remove misleading output text

Change History (2)

comment:1 Changed 8 years ago by acc

  • Owner changed from NEMO team to acc

I agree this is poorly done but its not quite as bad as it seems at first glance. The arrays are allocated unnecessarily but no work is done if ln_neptsimp is false due to the return statement:

      IF( ln_neptsimp ) THEN
          IF(lwp) WRITE(numout,*) ' -->   ln_neptsimp enabled, solving for U-UN'
      ELSE
          IF(lwp) WRITE(numout,*) ' -->   ln_neptsimp disabled'
          RETURN
      ENDIF

I'll move the allocation below this and correct the misleading output to ocean.output

comment:2 Changed 8 years ago by acc

  • Resolution set to fixed
  • Status changed from new to closed

Fixed on both the 2012/dev_MERGE_2012 branch and the trunk in preparation for the 3.4.1 consolidation.

Note: See TracTickets for help on using tickets.