Opened 7 years ago

Closed 7 years ago

#1089 closed Bug (worksforme)

error in NAMELIST declaration in OPA_SRC/BDY/bdydta.F90 ?

Reported by: clevy Owned by: nemo
Priority: low Milestone:
Component: OCE Version: release-3.5
Severity: Keywords:
Cc:

Description

I wonder if there might be an error in NAMELIST declaration in OPA_SRC/BDY/bdydta.F90 :For now, the sequence is:

      NAMELIST/nambdy_dta/ cn_dir, bn_tem, bn_sal, bn_u3d, bn_v3d, bn_ssh, bn_u2d, bn_v2d 
#if defined key_lim2
      NAMELIST/nambdy_dta/ bn_frld, bn_hicif, bn_hsnif
#endif
      NAMELIST/nambdy_dta/ ln_full_vel

As I read these 3 lines, it means that

#if defined key_lim2
      NAMELIST/nambdy_dta/ bn_frld, bn_hicif, bn_hsnif

and in all other cases

      NAMELIST/nambdy_dta/ ln_full_vel

My guess is that there are some missing continuation lines in there, which corresponds also to the values of &namby_dta in the namelist file.
I cannot make a full test with AMM12 for now, so that comments of experts are welcome

Commit History (0)

(No commits)

Change History (2)

comment:1 Changed 7 years ago by davestorkey

The syntax for this NAMELIST declaration is different from what is done in the rest of the NEMO code. In the rest of the code there is a single NAMELIST statement for each namelist and continuation lines are used if necessary. Here there are multiple NAMELIST declarations for the same namelist. I have done a test with the Met Office MED12 configuration and I think this syntax works (all values in the namelist are set correctly in my test), ie. there is no bug. But it might be a good idea to change the syntax to make it consistent with the rest of NEMO. I will do this in with the rest of my 3.6 changes.

Are you happy for me to close the ticket Claire?

Dave

comment:2 Changed 7 years ago by davestorkey

  • Resolution set to worksforme
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.