Opened 7 years ago

Closed 7 years ago

Last modified 3 years ago

#1133 closed Defect (fixed)

Compatibility between bdy and Agrif

Reported by: jchanut Owned by: nemo
Priority: normal Milestone:
Component: AGRIF Version: release-3.6
Severity: Keywords: BDY
Cc:

Description

There are several issues to be fixed to use Agrif with key_bdy (a likely situation for regional modelers). For the time being, the compilation with key_agrif and key_bdy fails.

Commit History (2)

ChangesetAuthorTimeChangeLog
4370jchanut2014-01-23T18:13:16+01:00

Time split cleaning / AMM12 restart / BDY and Agrif. See tickets #1228, #1227, #1225 and #1133

4354jchanut2014-01-17T17:56:32+01:00

Restore AGRIF and BDY compatibility, see ticket #1133

Change History (9)

comment:1 Changed 7 years ago by jchanut

  • Version changed from trunk to nemo_v3_6_alpha

comment:2 Changed 7 years ago by jchanut

Summary of changes:

  • Less vertical summations to compute barotropic velocities:
  • these are now defined at each baroclinic time step in oce.F90 as ua_b/va_b, un_b/vn_b, ub_b/vb_b
  • "now" and "before" values are computed after initialization in istate.F90 and at each baroclinic time step end in dynnxt.F90
  • This allows to suppress pointer arrays for barotropic variables in bdy_oce.F90 and elsewhere in the code.
  • Add AGRIF compilation directives in bdydta.F90 and bdytides.F90 modules
  • Pass barotropic arrays by arguments in bdydyn2d routines.
  • Allocate and initialize bdyxmask arrays in nemogcm instead of bdyini. These are used in several places of the code whatever lk_bdy value is.

Note that lk_bdy=.FALSE. on child grid domains so that one can only use key_bdy fonctionalities on the root grid

Results:

Modifications have been implemented in AMM12, from the code revision 4353, without key_iomput:

  • Compilation is now ok when key_bdy and key_agrif are defined (with key_vvl and key_tide also btw)
  • Changes give identical results to previous version with and without key_agrif defined (with no child grid !)

Code Revision: 4354

comment:3 Changed 7 years ago by jchanut

  • Resolution set to fixed
  • Status changed from new to closed

comment:4 Changed 4 years ago by nicolasmartin

  • Keywords agrif removed

comment:5 Changed 4 years ago by nicolasmartin

  • Keywords BDY added; bdy removed

comment:6 Changed 4 years ago by nicolasmartin

  • Keywords nemo_v3_6* added

comment:7 Changed 4 years ago by nicolasmartin

  • Milestone AGRIF deleted

Milestone AGRIF deleted

comment:8 Changed 3 years ago by nemo

  • Keywords release-3.6* added; nemo_v3_6* removed

comment:9 Changed 3 years ago by nemo

  • Keywords release-3.6* removed
Note: See TracTickets for help on using tickets.