default definition of nam_vvl

[smasson]

the logical namelist parameters of domvvl (nam_vvl namelist) have a default definition in domvvl.F90 and in namelist_ref.

!!* Namelist nam_vvl
LOGICAL , PUBLIC :: ln_vvl_zstar = .FALSE.             ! zstar  vertical coordinate
LOGICAL , PUBLIC :: ln_vvl_ztilde = .FALSE.            ! ztilde vertical coordinate
LOGICAL , PUBLIC :: ln_vvl_layer = .FALSE.             ! level  vertical coordinate
LOGICAL , PUBLIC :: ln_vvl_ztilde_as_zstar = .FALSE.   ! ztilde vertical coordinate
LOGICAL , PUBLIC :: ln_vvl_zstar_at_eqtor = .FALSE.    ! ztilde vertical coordinate
LOGICAL , PUBLIC :: ln_vvl_kepe = .FALSE.              ! kinetic/potential energy transfer
LOGICAL , PUBLIC :: ln_vvl_dbg = .FALSE.               ! debug control prints

As the introduction of namelist_ref was aiming to remove the "hidden" default definitions hard coded, I would suggest to suppress them also in domvvl.

Did I miss something?

[smasson]

same story for asminc.F90

   LOGICAL, PUBLIC :: ln_bkgwri = .FALSE.      !: No output of the background state fields
   LOGICAL, PUBLIC :: ln_asmiau = .FALSE.      !: No applying forcing with an assimilation increment
   LOGICAL, PUBLIC :: ln_asmdin = .FALSE.      !: No direct initialization
   LOGICAL, PUBLIC :: ln_trainc = .FALSE.      !: No tracer (T and S) assimilation increments
   LOGICAL, PUBLIC :: ln_dyninc = .FALSE.      !: No dynamics (u and v) assimilation increments
   LOGICAL, PUBLIC :: ln_sshinc = .FALSE.      !: No sea surface height assimilation increment
   LOGICAL, PUBLIC :: ln_seaiceinc             !: No sea ice concentration increment
   LOGICAL, PUBLIC :: ln_salfix = .FALSE.      !: Apply minimum salinity check
   LOGICAL, PUBLIC :: ln_temnofreeze = .FALSE. !: Don't allow the temperature to drop below freezing

[timgraham]

Hi Seb,

This makes sense for both of the routines above where they are logicals but just a plea to be careful about removing the defaults in routines such as diaobs where the namelist fields are allocatable arrays:

      enactfiles(:) = ''
      coriofiles(:) = ''
      profbfiles(:) = ''
      slafilesact(:) = ''
      slafilespas(:) = ''
      slafbfiles(:) = ''
      sstfiles(:)   = ''
      sstfbfiles(:) = ''
      seaicefiles(:) = ''
      velcurfiles(:) = ''
      veladcpfiles(:) = ''
      velavcurfiles(:) = ''
      velhrcurfiles(:) = ''
      velavadcpfiles(:) = ''
      velhradcpfiles(:) = ''
      velfbfiles(:) = ''
      velcurfiles(:) = ''
      veladcpfiles(:) = ''
      endailyavtypes(:) = -1
      endailyavtypes(1) = 820
      ln_profb_ena(:) = .FALSE.
      ln_profb_enatim(:) = .TRUE.
      ln_velfb_av(:) = .FALSE.

In this case I don't think it's possible to do this in namelist_ref because the size of the arrays is dependent on the model run. This got broken in the past (although the OBS SETTE test should detect this now).

[mocavero]

The default values have been added to fix the ticket #1392. The routine tra_adv uses the ln_vvl_ztilde parameter without conditioning to the lk_vvl key. However, ln_vvl_ztilde is read from the namelist only if the lk_vvl key is active.