Opened 6 years ago

Closed 6 years ago

Last modified 4 months ago

#1499 closed Bug (fixed)

wrong intialization of adjoint tests

Reported by: avidard Owned by: nemo
Priority: low Milestone:
Component: TAM Version: release-3.4
Severity: Keywords: TAM
Cc:

Description

While a clean field for the direct model has halos, wraparound and northfold properly filled (so that a lnc_lnk won't change a bit), a clean adjoint field has halos, wraparound and northfold zeroed (so that a lnc_lnk_adj won't change a bit).

As it is done now in adjoint tests, adjoint variables are set to 0 then initialized with loops over nl[de][ij]. So halos are indeed zeroed, but not wraparound nor northfold.

A solution would be to use tmaks_i, but then one also need u- and v- equivalents that do not exist (yet).

This only affect modules with a lbc_lnk_adj in it and does not seem to have a huge impact on test results (why bother :-()

Important note to NEMOTAM users: the above is true for any input of the adjoint (final condition or forcing), make sure their halos, wraparound and northfold are set to 0.

Attached are example of lbc_lnk_adj to different masks. From stupid (tmask) to what is done currently (nld_nle_loops) and what should be done (tmsk_i)

Commit History (1)

ChangesetAuthorTimeChangeLog
13420smueller2020-08-21T13:42:12+02:00

Addition of interior masks as suggested in ticket #1499

Attachments (3)

tmsk_i.png (30.2 KB) - added by avidard 6 years ago.
tmask.png (32.3 KB) - added by avidard 6 years ago.
nld_nle_loops.png (38.9 KB) - added by avidard 6 years ago.

Download all attachments as: .zip

Change History (10)

Changed 6 years ago by avidard

Changed 6 years ago by avidard

Changed 6 years ago by avidard

comment:1 Changed 6 years ago by avidard

  • Component changed from OPA to OPA_TAM

comment:2 Changed 6 years ago by bouttier

  • Resolution set to fixed
  • Status changed from new to closed

comment:3 Changed 4 years ago by nicolasmartin

  • Keywords TAM added

comment:4 Changed 4 years ago by nicolasmartin

  • Keywords nemo_v3_4* added

comment:5 Changed 3 years ago by nemo

  • Keywords release-3.4* added; nemo_v3_4* removed

comment:6 Changed 3 years ago by nemo

  • Keywords release-3.4* removed

comment:7 Changed 4 months ago by smueller

In 13420:

Addition of interior masks as suggested in ticket #1499

Note: See TracTickets for help on using tickets.