Opened 5 years ago

Closed 5 years ago

Last modified 3 years ago

#1566 closed Bug (fixed)

ORCA1 strait corrections have the wrong indices

Reported by: acc Owned by: nemo
Priority: normal Milestone: 2015 release-3.6
Component: OCE Version: release-3.6
Severity: Keywords: 2015
Cc:

Description

The control on the hard-wired indices for the two manifestations of ORCA1 (extended or otherwise) is faulty. The current logic has constructs such as:

  isrow = 332 - jpjglo
            !
            ii0 = 282           ;   ii1 = 283        ! Gibraltar Strait (e2u = 20 km)
            ij0 = 201 + isrow   ;   ij1 = 241 - isrow   ;   e2u( mi0(ii0):mi1(ii1) , mj0(ij0):mj1(ij1) ) =  20.e3

but Gibraltar is either at j=241 (extended grid, jpjglo=332) or at 203 (non-extended, jpjglo=294). Surely the statement should be:

  isrow = 332 - jpjglo
            !
            ii0 = 282           ;   ii1 = 283        ! Gibraltar Strait (e2u = 20 km)
            ij0 = 241 - isrow   ;   ij1 = 241 - isrow   ;   e2u( mi0(ii0):mi1(ii1) , mj0(ij0):mj1(ij1) ) =  20.e3

unless I'm missing something very subtle?

Commit History (2)

ChangesetAuthorTimeChangeLog
5552acc2015-07-06T18:45:56+02:00

#1566 Fix ORCA1 strait corrections in domhgr.F90 and dommsk.F90. trunk

5551acc2015-07-06T18:38:51+02:00

#1566 Fix ORCA1 strait corrections in domhgr.F90 and dommsk.F90. nemo_v3_6_STABLE

Change History (4)

comment:1 Changed 5 years ago by acc

  • Resolution set to fixed
  • Status changed from new to closed

Fixed at revisions 5551 (3.6_STABLE) and 5552 (trunk)

comment:2 Changed 4 years ago by nicolasmartin

  • Keywords 2015 nemo_v3_6* added

comment:3 Changed 3 years ago by nemo

  • Keywords release-3.6* added; nemo_v3_6* removed

comment:4 Changed 3 years ago by nemo

  • Keywords release-3.6* removed
Note: See TracTickets for help on using tickets.