Opened 13 years ago

Closed 12 years ago

#159 closed Enhancement (fixed)

nemo trunk : diadimg still use OPEN statement instead of ctlopn

Reported by: molines@… Owned by: rblod
Priority: low Milestone:
Component: OCE Version: release-2
Severity: Keywords:
Cc: Review:
MP ready?:
Progress:

Description

I attach to this ticket the correct version of diadimg ( using ctlopn )

JM Molines

Commit History (1)

ChangesetAuthorTimeChangeLog
1106rblod2008-06-10T18:24:12+02:00

Correct diawri_dimg according to the new sbc, see ticket #159

Attachments (1)

diadimg.F90 (6.8 KB) - added by nemo_user 13 years ago.
diadimg.F90

Download all attachments as: .zip

Change History (6)

Changed 13 years ago by nemo_user

diadimg.F90

comment:1 follow-up: Changed 12 years ago by rblod

  • Owner changed from NEMO team to rblod
  • Status changed from new to assigned

To use dimg option, I had also to change diawri_dimg.h90 :

  • sst into sf_sst%fnow
  • qnr into qns (??)

I must confess I did it in a total non-professional way, I did not check the diagnostic before and after, and made the changes a lot "by eyes" with very few reflexion. It is totally against what we preached for in the last committee, shame on me

So I do not close this ticket, put I did the commit (rev 1057)

Rachid

comment:2 in reply to: ↑ 1 ; follow-up: Changed 12 years ago by nemo_user

Replying to rblod:

To use dimg option, I had also to change diawri_dimg.h90 :

  • sst into sf_sst%fnow
  • qnr into qns (??)

I must confess I did it in a total non-professional way, I did not check the diagnostic before and after, and made the changes a lot "by eyes" with very few reflexion. It is totally against what we preached for in the last committee, shame on me

So I do not close this ticket, put I did the commit (rev 1057)

Rachid

Some more information about this fix: the involved fields only concern the case when
an external 'sst' is used as feedback term on the heat flux. (nn_sstr = 1 ). In other cases (e.g. using bulk), it is non relevant. I notice that these fields are not saved in the standard 'diawri'. It is a remnant of the old CLIPPER days … and for the sake of simplicity I will just propose to suppress these 2 fields from the output.
But if you want to keep them … then there is a problem
as it is, because the sf_sst
structure is NOT allocated if nn_sstr /= 1.

Jean-Marc


comment:3 in reply to: ↑ 2 ; follow-up: Changed 12 years ago by rblod

Replying to nemo_user:

Replying to rblod:

To use dimg option, I had also to change diawri_dimg.h90 :

  • sst into sf_sst%fnow
  • qnr into qns (??)

I must confess I did it in a total non-professional way, I did not check the diagnostic before and after, and made the changes a lot "by eyes" with very few reflexion. It is totally against what we preached for in the last committee, shame on me

So I do not close this ticket, put I did the commit (rev 1057)

Rachid

Some more information about this fix: the involved fields only concern the case when
an external 'sst' is used as feedback term on the heat flux. (nn_sstr = 1 ). In other cases (e.g. using bulk), it is non relevant. I notice that these fields are not saved in the standard 'diawri'. It is a remnant of the old CLIPPER days … and for the sake of simplicity I will just propose to suppress these 2 fields from the output.
But if you want to keep them … then there is a problem
as it is, because the sf_sst
structure is NOT allocated if nn_sstr /= 1.

Jean-Marc


I'd rather follow the sake of simplicity, but suppressing these 2 fields wouldn't break you dimg post-processing ?

Rachid

comment:4 in reply to: ↑ 3 ; follow-up: Changed 12 years ago by nemo_user

Replying to rblod:

Replying to nemo_user:

Replying to rblod:

To use dimg option, I had also to change diawri_dimg.h90 :

  • sst into sf_sst%fnow
  • qnr into qns (??)

I must confess I did it in a total non-professional way, I did not check the diagnostic before and after, and made the changes a lot "by eyes" with very few reflexion. It is totally against what we preached for in the last committee, shame on me

So I do not close this ticket, put I did the commit (rev 1057)

Rachid

Some more information about this fix: the involved fields only concern the case when
an external 'sst' is used as feedback term on the heat flux. (nn_sstr = 1 ). In other cases (e.g. using bulk), it is non relevant. I notice that these fields are not saved in the standard 'diawri'. It is a remnant of the old CLIPPER days … and for the sake of simplicity I will just propose to suppress these 2 fields from the output.
But if you want to keep them … then there is a problem
as it is, because the sf_sst
structure is NOT allocated if nn_sstr /= 1.

Jean-Marc


I'd rather follow the sake of simplicity, but suppressing these 2 fields wouldn't break you dimg post-processing ?

Rachid

I should say that actually, these 2 fields are not post-processed :) . Of course, when you change the record number for the other fields there will be an impact, which requires an update of the post-processing. I suggest that those fields which are not used anymore can me marked as 'spare' and left empty of any purpose. Anyway, this is
probably very 'provisoire' before the IOM output, is n't it ?
The only concern is to be sure that it is initialized (I think it is the case). There are no concern about disk space for the files, as those files are not stored for a long time. (They are just deleted when succesfully processed).

Jean-Marc

comment:5 in reply to: ↑ 4 Changed 12 years ago by rblod

  • Resolution set to fixed
  • Status changed from assigned to closed

Replying to nemo_user:

Replying to rblod:

Replying to nemo_user:

Replying to rblod:

To use dimg option, I had also to change diawri_dimg.h90 :

  • sst into sf_sst%fnow
  • qnr into qns (??)

I must confess I did it in a total non-professional way, I did not check the diagnostic before and after, and made the changes a lot "by eyes" with very few reflexion. It is totally against what we preached for in the last committee, shame on me

So I do not close this ticket, put I did the commit (rev 1057)

Rachid

Some more information about this fix: the involved fields only concern the case when
an external 'sst' is used as feedback term on the heat flux. (nn_sstr = 1 ). In other cases (e.g. using bulk), it is non relevant. I notice that these fields are not saved in the standard 'diawri'. It is a remnant of the old CLIPPER days … and for the sake of simplicity I will just propose to suppress these 2 fields from the output.
But if you want to keep them … then there is a problem
as it is, because the sf_sst
structure is NOT allocated if nn_sstr /= 1.

Jean-Marc


I'd rather follow the sake of simplicity, but suppressing these 2 fields wouldn't break you dimg post-processing ?

Rachid

I should say that actually, these 2 fields are not post-processed :) . Of course, when you change the record number for the other fields there will be an impact, which requires an update of the post-processing. I suggest that those fields which are not used anymore can me marked as 'spare' and left empty of any purpose. Anyway, this is
probably very 'provisoire' before the IOM output, is n't it ?
The only concern is to be sure that it is initialized (I think it is the case). There are no concern about disk space for the files, as those files are not stored for a long time. (They are just deleted when succesfully processed).

Jean-Marc

I let it empty (set to zero) and didn't change the record numbers for the fields. I even did a run in activating dimg…..
I hope it is ok now.

Rachid

Note: See TracTickets for help on using tickets.