Opened 8 years ago
Closed 4 years ago
#1702 closed Task (fixed)
HPC-3(2016WP) - suppression of useless communications
Reported by: | timgraham | Owned by: | mathiot |
---|---|---|---|
Priority: | low | Milestone: | Unscheduled |
Component: | OCE | Version: | trunk |
Severity: | minor | Keywords: | |
Cc: |
Description
Description
Suppress unnecessary lbc_lnk calls in all parts of NEMO.
Analysis
Recommendation
Commit History (2)
Changeset | Author | Time | ChangeLog |
---|---|---|---|
12269 | mathiot | 2019-12-18T11:34:35+01:00 | remove useless lbc_lnk in eosbn2 (rab2d and insitu2d) as suggested in comments of #1702 (no change in results in SETTE configurations) |
12268 | mathiot | 2019-12-18T11:28:06+01:00 | remove useless lbc_lnk in eosbn2 (rab2d and insitu2d) as suggested in comments of #1702 (no change in results in SETTE configurations) |
Change History (9)
comment:1 Changed 8 years ago by lovato
comment:2 Changed 6 years ago by nicolasmartin
- Owner changed from nemo to timgraham
- Status changed from new to assigned
comment:3 Changed 6 years ago by nemo
- Type changed from Development to Task
Remove 'Development' type
comment:4 Changed 6 years ago by nemo
- Milestone set to Unscheduled
Batch modification of milestone field set to 'Unscheduled'
comment:5 Changed 6 years ago by nicolasmartin
- Owner changed from timgraham to mathiot
- Severity set to minor
Need a clear statement on this work, is it still relevant now and if so who is the new PI.
comment:6 Changed 5 years ago by nicolasmartin
- Summary changed from HPC-3 - suppression of useless communications to HPC-3(2016WP) - suppression of useless communications
comment:7 Changed 4 years ago by mathiot
In 12268:
comment:8 Changed 4 years ago by mathiot
In 12269:
comment:9 Changed 4 years ago by mathiot
- branch_review set to pending
- mp_status set to yes
- Resolution set to fixed
- Status changed from assigned to closed
Suggestion implemented in the merge branch. As the action is 4 years old, if the action is still valid, I suggest to start again the process for the 2020 WP and create a new wiki page in the 2020WP before the developer commitee for discussion.
Hi Tim,
I found something that can likely be part of this activity for the suppression of unnecessary lbc_lnk calls.
In subroutine rab_2d (contained in OPA_SRC/TRA/eosbn2.F90) the main loop is structured as for vector_loop option, with the consequent call to lbc_lnk,
while the equivalent subroutine for 3D case, rab_3d, is coded with the static index loop over jpi,jpj,jpk (and without the call to lbc_lnk).
I think we can reinstate the static loop indexes (jpi,jpj) into rab_2d and remove the following call to lbc_lnk.