Opened 4 years ago

Closed 8 months ago

#1702 closed Task (fixed)

HPC-3(2016WP) - suppression of useless communications

Reported by: timgraham Owned by: mathiot
Priority: low Milestone: Unscheduled
Component: OCE Version: trunk
Severity: minor Keywords:
Cc: Review: pending
MP ready?: yes
Progress:

Description

Description

Suppress unnecessary lbc_lnk calls in all parts of NEMO.

Analysis

Recommendation

Commit History (2)

ChangesetAuthorTimeChangeLog
12269mathiot2019-12-18T11:34:35+01:00

remove useless lbc_lnk in eosbn2 (rab2d and insitu2d) as suggested in comments of #1702 (no change in results in SETTE configurations)

12268mathiot2019-12-18T11:28:06+01:00

remove useless lbc_lnk in eosbn2 (rab2d and insitu2d) as suggested in comments of #1702 (no change in results in SETTE configurations)

Change History (9)

comment:1 Changed 4 years ago by lovato

Hi Tim,

I found something that can likely be part of this activity for the suppression of unnecessary lbc_lnk calls.

In subroutine rab_2d (contained in OPA_SRC/TRA/eosbn2.F90) the main loop is structured as for vector_loop option, with the consequent call to lbc_lnk,

while the equivalent subroutine for 3D case, rab_3d, is coded with the static index loop over jpi,jpj,jpk (and without the call to lbc_lnk).

I think we can reinstate the static loop indexes (jpi,jpj) into rab_2d and remove the following call to lbc_lnk.

comment:2 Changed 3 years ago by nicolasmartin

  • Owner changed from nemo to timgraham
  • Status changed from new to assigned

comment:3 Changed 3 years ago by nemo

  • Type changed from Development to Task

Remove 'Development' type

comment:4 Changed 2 years ago by nemo

  • Milestone set to Unscheduled

Batch modification of milestone field set to 'Unscheduled'

comment:5 Changed 2 years ago by nicolasmartin

  • Owner changed from timgraham to mathiot
  • Severity set to minor

Need a clear statement on this work, is it still relevant now and if so who is the new PI.

comment:6 Changed 23 months ago by nicolasmartin

  • Summary changed from HPC-3 - suppression of useless communications to HPC-3(2016WP) - suppression of useless communications

comment:7 Changed 8 months ago by mathiot

In 12268:

remove useless lbc_lnk in eosbn2 (rab2d and insitu2d) as suggested in comments of #1702 (no change in results in SETTE configurations)

comment:8 Changed 8 months ago by mathiot

In 12269:

remove useless lbc_lnk in eosbn2 (rab2d and insitu2d) as suggested in comments of #1702 (no change in results in SETTE configurations)

comment:9 Changed 8 months ago by mathiot

  • MP ready? set to yes
  • Resolution set to fixed
  • Review set to pending
  • Status changed from assigned to closed

Suggestion implemented in the merge branch. As the action is 4 years old, if the action is still valid, I suggest to start again the process for the 2020 WP and create a new wiki page in the 2020WP before the developer commitee for discussion.

Note: See TracTickets for help on using tickets.