New URL for NEMO forge!   http://forge.nemo-ocean.eu

Since March 2022 along with NEMO 4.2 release, the code development moved to a self-hosted GitLab.
This present forge is now archived and remained online for history.
#1788 (C1D_PAPA with TOP do not compile) – NEMO

Opened 7 years ago

Last modified 2 years ago

#1788 closed Bug

C1D_PAPA with TOP do not compile — at Initial Version

Reported by: lovato Owned by: lovato
Priority: lowest Milestone: Unscheduled
Component: TOP Version: v3.6
Severity: Keywords: C1D Miscellaneous TOP v3.6
Cc: lovato, timgraham

Description

Context

Use the 1D configuration with OPA and TOP in NEMO3.6 (and trunk) generate compilation bug.

Analysis

The bug arise in the module trcsub, when accessing with use only instance to the memory of zdfgls

 21 #if defined key_zdfgls
 22    USE zdfgls, ONLY: en
 23 #endif

Fix

The simplest solution is to remove the use only of memory in the 3.6_stable code and also in the trunk

 21 #if defined key_zdfgls
 22    USE zdfgls
 23 #endif

In addition, also the step subroutine of C1D should be updated to properly initialize xios information

NEMOGCM/NEMO/OPA_SRC/C1D/step_c1d.F90

@@ -59,9 +59,9 @@ CONTAINS

       !! ---------------------------------------------------------------------

                              indic = 0                ! reset to no error condition
-      IF( kstp == nit000 )   CALL iom_init( "nemo")   ! iom_put initialization (must be done after nemo_init for AGRIF+XIOS+OASIS)
+      IF( kstp == nit000 )   CALL iom_init( cxios_context )   ! iom_put initialization (must be done after nemo_init for AGRIF+XIOS+OASIS)
       IF( kstp /= nit000 )   CALL day( kstp )         ! Calendar (day was already called at nit000 in day_init)
-                             CALL iom_setkt( kstp - nit000 + 1, "nemo" )   ! say to iom that we are at time step kstp
+                             CALL iom_setkt( kstp - nit000 + 1, cxios_context )   ! say to iom that we are at time step kstp

Commit History (4)

ChangesetAuthorTimeChangeLog
7091lovato2016-10-25T16:52:34+02:00

#1788 - trunk: bugfix for memory use association in trcsub

7088lovato2016-10-25T16:35:26+02:00

#1788 - revise bugfix for memory use association in trcsub

7080lovato2016-10-24T18:37:19+02:00

#1788 - Solve compilation bug of C1D when including TOP component

7079lovato2016-10-24T18:30:30+02:00

#1788 - trunk: Solve compilation bug of C1D when including TOP component

Change History (0)

Note: See TracTickets for help on using tickets.