id summary reporter owner description type status priority milestone component version severity resolution keywords cc 1853 Land Suppression in mppini_2.h90 not working jamesharle jamesharle "= Context = I was just testing a simple 13x13 decomposition and wanted to suppress the land cells (about 30% of the domain), but got an ERROR telling me that jpnij should equal 169. = Analysis = Land suppression in mppini_2.h90 appears to be redundant as the conditional WHERE( zbot(:,:) - ztop(:,:) + 1 > 0 ) ; imask(:,:) = 1 is never realised. I'm not too sure I can think of an example where ztop(:,:) would be greater than zbot(:,:)? I guess the +1 was put there incase there was only 1 wet cell (i.e. zbot=ztop=1) or some under ice feature. The problem being there is also the case where zbot=ztop=0 (i.e. it's land). Just from an ocean only run point of view I would have thought just defining the land suppression mask using zbot alone would be sufficient (i.e. where zbot > 0 there is a wet point) - but I may have missed some subtlety in the code somewhere (probably in relation to ice). Please confirm! = Fix = {{{ 102c102 < WHERE( zbot(:,:) - ztop(:,:) + 1 > 0 ) ; imask(:,:) = 1 --- > WHERE( zbot(:,:) > 0 ) ; imask(:,:) = 1 }}} " Bug closed low OCE trunk fixed