Opened 3 years ago

Closed 2 years ago

#1919 closed Bug (fixed)

Variables passed to iom_put with no definition in field_def*.xml files

Reported by: timgraham Owned by: emanuelaclementi
Priority: low Milestone:
Component: OCE Version: trunk
Severity: minor Keywords:
Cc:

Description (last modified by nicolasmartin)

Context

I have modified Seb's script (NEMOGCM/TOOLS/MISCELLANEOUS/chk_iomput.F90) to check for variables passed to XIOS with no corresponding definition in the field_def files so that is works with the split field_def files in the trunk. I'll commit the change shortly) but for now it has shown that the following iom_put calls have no variable definition in the field_def files.

../../NEMO/OPA_SRC/TRD/trdmxl.F90:         CALL iom_put( "mxl_depth", hmxl(:,:) )
../../NEMO/OPA_SRC/TRD/trdmxl.F90:         CALL iom_put( "mxl_depth", hmxl_sum(:,:) )
../../NEMO/TOP_SRC/C14/trcwri_c14.F90:         CALL iom_put( "qint_c14" , qint_c14  )                       ! cumulative flux [./m2]
../../NEMO/TOP_SRC/C14/trcwri_c14.F90:         CALL iom_put( "qtr_c14", rsiyea * qtr_c14(:,:)  )            !  Radiocarbon surf flux [./m2/yr]
../../NEMO/OPA_SRC/TRD/trdmxl.F90:         CALL iom_put( "sml"    , sml    (:,:) )
../../NEMO/OPA_SRC/TRD/trdmxl.F90:         CALL iom_put( "sml"    , sml_sum (:,:) )
../../NEMO/OPA_SRC/TRD/trdmxl.F90:         CALL iom_put( "sml_res", zsmlres(:,:) ) 
../../NEMO/OPA_SRC/TRD/trdmxl.F90:         CALL iom_put( "sml_res", zsmlres2(:,:) ) 
../../NEMO/OPA_SRC/TRD/trdmxl.F90:         CALL iom_put( "sml_tot", zsmltot(:,:) ) 
../../NEMO/OPA_SRC/TRD/trdmxl.F90:         CALL iom_put( "sml_tot", zsmltot2(:,:) ) 
../../NEMO/OPA_SRC/TRD/trdmxl.F90:         CALL iom_put( "tml"     , tml    (:,:) ) 
../../NEMO/OPA_SRC/TRD/trdmxl.F90:         CALL iom_put( "tml"     , tml_sum (:,:) ) 
../../NEMO/OPA_SRC/TRD/trdmxl.F90:         CALL iom_put( "tml_res" , ztmlres(:,:) ) 
../../NEMO/OPA_SRC/TRD/trdmxl.F90:         CALL iom_put( "tml_res" , ztmlres2(:,:) ) 
../../NEMO/OPA_SRC/TRD/trdmxl.F90:         CALL iom_put( "tml_tot" , ztmltot(:,:) ) 
../../NEMO/OPA_SRC/TRD/trdmxl.F90:         CALL iom_put( "tml_tot" , ztmltot2(:,:) ) 
../../NEMO/OPA_SRC/SBC/sbcwave.F90:      CALL iom_put( "ustokes",  usd  )
../../NEMO/OPA_SRC/SBC/sbcwave.F90:      CALL iom_put( "vstokes",  vsd  )
../../NEMO/OPA_SRC/SBC/sbcwave.F90:      CALL iom_put( "wstokes",  wsd  )

Recommendation

Definitions for these variables should be added to the appropriate field_def files.

Commit History (1)

ChangesetAuthorTimeChangeLog
9812lovato2018-06-19T17:33:35+02:00

trunk : add missing variables for wave coupling in field_def_nemo-oce.xml - #1919

Change History (7)

comment:1 Changed 3 years ago by nicolasmartin

  • Description modified (diff)
  • Owner nemo deleted
  • Status changed from new to assigned

comment:2 Changed 3 years ago by clevy

  • Owner set to emanuelaclementi

comment:3 Changed 3 years ago by nemo

  • Keywords Misc. added

comment:4 Changed 3 years ago by nemo

  • Keywords Misc. removed

comment:5 Changed 3 years ago by nicolasmartin

  • Milestone Miscellaneous deleted
  • Severity set to minor

comment:6 Changed 2 years ago by lovato

In 9812:

trunk : add missing variables for wave coupling in field_def_nemo-oce.xml - #1919

comment:7 Changed 2 years ago by lovato

  • Resolution set to fixed
  • Status changed from assigned to closed

The variables related to wave component in the trunk, namely ustokes, vstokes, and wstokes were added to the SHARED/field_def_nemo-oce.xml file at revision r9812.

The output fields related to C14 are already included in the trunk at least from revision r9596.

The other variables listed in the ticket (mxl_depth, sml*, tml*) are contained in the set of routines to compute the T/S trends within the mixed layer in src/OCE/TRD/trdmxl.F90.
Actually this part of the code was revised with the changes to the diagnostic trend computations (activated from namtrd using the logical ln_tra_mxl)
is never used in the standard configurations and probably need some testing.

Thus the inclusion of these missing variables for XIOS in the xml file should be check along with the revision of the code for T/S trends computation in the mixed layer
(actually due to the sound revision of the repo I was not able to track back the full history of this development).

Note: See TracTickets for help on using tickets.