Opened 12 years ago

Closed 12 years ago

#203 closed Bug (fixed)

minor bug in tranpc.F90

Reported by: gm Owned by: nemo
Priority: low Milestone:
Component: OCE Version: trunk
Severity: Keywords:


The npc algorithm should be applied to ta before the Asselin filter is applied otherwise, residual static instabilities can be added to tn, sn (tb,sb after the swap) via the Asselin filter. Therefore, in step.F90, the tranpc call is moved before the call to tranxt, and in tranpc we use ta, sa fields and not tn, sn fields.

tranpc and step are given in attachment. The main changes are:

tranpc.F90 =⇒ switch the use of tn,sn to the use of ta, sa

step.F90 =⇒ Change the order of call for tranpc et tranxt + some modified the comments (sorry…)

the main changes in comments of step.F90 are:

+ move USE domvvl from the last USE to one of the first (just below USE daymod)

+ compact form for initial state writing (in 1 line) :

IF( ninist == 1 ) THEN ; CALL dia_wri_state( 'output.init' ) ; ninist = 0 ; ENDIF

+ compact set to zero of inital trends (in 1 line)

ta(:,:,:) = 0.e0 ; sa(:,:,:) = 0.e0 ! initial tracer trends is zero

ua(:,:,:) = 0.e0 ; va(:,:,:) = 0.e0 ! initial dynamics trends is zero

Commit History (1)


trunk: remove a small bug related to the non-penetrative convective adjustment scheme, see ticket: #203

Attachments (2)

tranpc.F90 (11.0 KB) - added by gm 12 years ago.
step.F90 (19.7 KB) - added by gm 12 years ago.

Download all attachments as: .zip

Change History (4)

Changed 12 years ago by gm

Changed 12 years ago by gm

comment:1 Changed 12 years ago by gm

CAUTION these modifications can only be done after the ticket #202 as it requires the time stepping to be done in trazdf routines (including trazdf_exp.F90)

comment:2 Changed 12 years ago by ctlod

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.