Opened 7 months ago

Closed 6 weeks ago

#2073 closed Defect (fixed)

Out of bounds of passive tracers when using PISCES or another SMS model together with CFC

Reported by:cetlod Component: TOP
Version: release-3.6 Severity: minor
Keywords: Cc:
Management
Owned by:cetlod Milestone:
Priority: low

Description (last modified by nicolasmartin)

Context

NEMO-TOP is designed to be able to simulate SMS models and inert tracers at the same time. When trying to uses PISCES+CFC the model crashes because the tracer loop is not well defined in the main CFC routine

Analysis

in trcsms_cfc.F90, an out-of-bounds occurs when trying to read and write the cumulative fluxes in the restart

Recommendation

the loop below

         DO jn = jp_cfc0, jp_cfc1
            CALL iom_rstput( kt, nitrst, numrtw, 'qint_'//ctrcnm(jn), qint_cfc(:,:,jn) )
         END DO

should be

         jl = 0
         DO jn = jp_cfc0, jp_cfc1
            jl = jl + 1
            CALL iom_get( numrtr, jpdom_autoglo, 'qint_'//ctrcnm(jn), qint_cfc(:,:,jl) )
         END DO


Commit History (2)

ChangesetAuthorTimeChangeLog
9456cetlod2018-04-04T09:24:34+02:00

dev_merge : Bugfix to avoid out-of-bounds in CFC model, see ticket #2073

9455cetlod2018-04-04T09:21:45+02:00

Bugfix to avoid out-of-bounds in CFC model, see ticket #2073

Change History (5)

comment:1 Changed 7 months ago by cetlod

In 9455:

Bugfix to avoid out-of-bounds in CFC model, see ticket #2073

Code review status: pending

comment:2 Changed 7 months ago by cetlod

In 9456:

dev_merge : Bugfix to avoid out-of-bounds in CFC model, see ticket #2073

Code review status: pending

comment:3 Changed 7 months ago by nicolasmartin

  • Description modified (diff)

comment:4 Changed 6 months ago by nicolasmartin

  • Owner set to cetlod
  • Status changed from new to assigned

comment:5 Changed 6 weeks ago by cetlod

  • Component changed from OCE to TOP
  • Resolution set to fixed
  • Status changed from assigned to closed

Done in v4.0

Note: See TracTickets for help on using tickets.