Opened 6 years ago
Closed 4 years ago
#2094 closed Defect (fixed)
closea behaviour if closea_mask not present
Reported by: | mathiot | Owned by: | mathiot |
---|---|---|---|
Priority: | low | Milestone: | 2019 WP |
Component: | OCE | Version: | trunk |
Severity: | minor | Keywords: | closed_seas, |
Cc: |
Description
Context
I found the behaviour of closea a bit dangerous (ie potential source of bug for the user).
If closea_mask is not present in domain_cfg, ln_closea has no effect and only a small comments is written in ocean.output:
==>>> closea_mask field not found in domain_cfg file. No closed seas defined.
It looks very easy to miss this information and run a long simulation thinking the closed sea are removed (for example).
Suggestion
I think it is safer to set a integer switch:
- nn_closea = 0 ! => nothing is done (closea_mask defined or not)
- nn_closea = 1 ! => closed sea are removed using closea_mask (error raised if variable are missing)
- nn_closea = 2 ! => special treatment for closed sea using fields defined in domain_cfg.nc (error raised if variables are missing)
Concerning the removal of closed sea:
As improvement, we could used a 2d flood filling algorithm to do the job (ie detect the main ocean and mask everything else). It will remove the need of a closea_mask and the definition of all the hard coded indexes in DOMAINcfg. Similar work as already been done in 3d in UKMO/dev_isf_remapping_UKESM_GO6package_r9314@9513 for the removal of subglacial lake beneath the ice shelf. The only extra input needed in the namelist will be the coordinates in lat/lon of a seed in the main ocean (default could be (0,0) to work with all eORCA and ORCA configuration).
Commit History (0)
(No commits)
Change History (3)
comment:1 Changed 6 years ago by nemo
- Owner set to mathiot
- Status changed from new to assigned
comment:2 Changed 5 years ago by mathiot
- Milestone changed from 2018 release-4.0 to 2019 WP
comment:3 Changed 4 years ago by mathiot
- Resolution set to fixed
- Status changed from assigned to closed
Fixed by the merge 2019. Will be included once the trunk updated to the merge branch
Move in 2019 WP as part of ENHANCE-03_PierreMathiot_DomcfgTools.