Opened 2 years ago

Closed 2 years ago

#2120 closed Bug (fixed)

Bug in vertical advection with ice shelf and vector form

Reported by: mathiot Owned by: mathiot
Priority: low Milestone: 2018 release-4.0
Component: OCE Version: trunk
Severity: minor Keywords: ISF, advection
Cc:

Description

Context

There is a bug in the vertical advection in case of opened ice shelf cavity with vector form. The vertical advection is masked at u-,v- w points on the top interface. It should not. It should be done as for the bottom interface (no masking). (thank you Gurvan and Andrew).

Analysis

It affect all simulation running with ice shelf cavity open and vector form with the trunk and 3.6_STABLE.

Fix

replace in dynzad.F90:

      !
      ! Surface and bottom advective fluxes set to zero
      IF( ln_isfcav ) THEN
         DO jj = 2, jpjm1
            DO ji = fs_2, fs_jpim1           ! vector opt.
               zwuw(ji,jj, 1:miku(ji,jj) ) = 0._wp
               zwvw(ji,jj, 1:mikv(ji,jj) ) = 0._wp
               zwuw(ji,jj,jpk) = 0._wp
               zwvw(ji,jj,jpk) = 0._wp
            END DO
         END DO
      ELSE
         DO jj = 2, jpjm1
            DO ji = fs_2, fs_jpim1           ! vector opt.
               zwuw(ji,jj, 1 ) = 0._wp
               zwvw(ji,jj, 1 ) = 0._wp
               zwuw(ji,jj,jpk) = 0._wp
               zwvw(ji,jj,jpk) = 0._wp
            END DO
         END DO
      END IF

by:

      !
      ! Surface and bottom advective fluxes set to zero
      DO jj = 2, jpjm1
         DO ji = fs_2, fs_jpim1           ! vector opt.
            zwuw(ji,jj, 1 ) = 0._wp
            zwvw(ji,jj, 1 ) = 0._wp
            zwuw(ji,jj,jpk) = 0._wp
            zwvw(ji,jj,jpk) = 0._wp
         END DO
      END DO

ISOMIP is running fine with the fix with only minor change of the results.

Commit History (2)

ChangesetAuthorTimeChangeLog
9967mathiot2018-07-18T17:08:52+02:00

fix #2120 in 3.6_STABLE

9965mathiot2018-07-18T15:53:41+02:00

code change for #2120 in trunk

Change History (2)

comment:1 Changed 2 years ago by mathiot

In 9965:

code change for #2120 in trunk

comment:2 Changed 2 years ago by mathiot

  • Resolution set to fixed
  • Status changed from new to closed

In 9967:

fix #2120 in 3.6_STABLE

Note: See TracTickets for help on using tickets.