#226 closed Bug (fixed)
zdfddm.F90 old bug not corrected ...
Reported by: | molines@… | Owned by: | nemo |
---|---|---|---|
Priority: | low | Milestone: | |
Component: | OCE | Version: | v3.0 |
Severity: | Keywords: | ZDF | |
Cc: |
Description
In my own version I have applied a bug fix from Sebastien Masson (personal comm.) concerning zdfddm. I see that in the nemo3beta, the bug is still there. So, as a reminder, this concerns the following lines:
153 ! Update avt and avs 154 ! ------------------ 155 ! Constant eddy coefficient: reset to the background value 156 !CDIR NOVERRCHK 157 DO jj = 1, jpj 158 !CDIR NOVERRCHK 159 DO ji = 1, jpi 160 zinr = 1./rrau(ji,jj,jk) 161 ! salt fingering 162 zrr = rrau(ji,jj,jk)/hsbfr 163 zrr = zrr * zrr 164 zavfs = avts / ( 1 + zrr*zrr*zrr ) * zmsks(ji,jj) *zmskf(ji,jj) 165 zavft = 0.7 * zavfs * zinr 166 ! diffusive layering 167 zavdt = 1.3635e-6 * EXP(4.6*EXP(-0.54*(zinr-1.) ) ) & 168 * zmsks(ji,jj) * zmskd1(ji,jj) 169 zavds = zavdt * zmsks(ji,jj) & 170 * ( (1.85 * rrau(ji,jj,jk) - 0.85 ) * zmskd3(ji,jj) & 171 + 0.15 * rrau(ji,jj,jk) * zmskd2(ji,jj) ) 172 ! add to the eddy viscosity coef. previously computed 173 avs (ji,jj,jk) = avt(ji,jj,jk) + zavfs + zavds 174 avt (ji,jj,jk) = avt(ji,jj,jk) + zavft + zavdt 175 END DO 176 END DO
Cheers,
Jean-Marc
Commit History (1)
Changeset | Author | Time | ChangeLog |
---|---|---|---|
1163 | ctlod | 2008-07-08T17:11:10+02:00 | trunk: remove extra coefficient zavdt when computing zavds scalar in zdfddm.F90, see ticket: #226 |
Change History (2)
comment:1 Changed 16 years ago by ctlod
- Resolution set to fixed
- Status changed from new to closed
comment:2 Changed 8 years ago by nicolasmartin
- Keywords ZDF added; zdfddm removed
Note: See
TracTickets for help on using
tickets.