id summary reporter owner description type status priority milestone component version severity resolution keywords cc 2302 "SETTE fails to complete the AGRIF_DEMO test if ADD_NOSIGNEDZERO has been set to ""no""" smueller smueller " ==== Context The configuration `AGRIF_DEMO_NOAGRIF_ST`, which is set up as part of the SETTE test of the `AGRIF_DEMO` reference configuration, fails to run in a SETTE configuration where the value of `ADD_NOSIGNEDZERO` has been set to `""no""` since the initial setup of configuration `AGRIF_DEMO_NOAGRIF_ST`. This failure is not explicitly flagged up in the SETTE report, but it leads to the omission of the report from the comparison of output from matching runs compiled with and without `key_agrif`. ==== Analysis If variable `ADD_KEY` is an empty string or contains solely whitespace characters when `makenemo` is executed in scripts source:/utils/CI/sette/sette_reference-configurations.sh@11161 and source:/utils/CI/sette/sette_test-cases.sh@11161, `makenemo` interprets `del_key` as the value for the preceding `add_key` keyword argument instead of as an instruction to disable the specified preprocessor keys. When `ADD_NOSIGNEDZERO` has been set to `""no""`, `ADD_KEY` remains empty, and therefore keyword argument `del_key` does not have the intended effect; in the case of configuration `AGRIF_DEMO_NOAGRIF_ST` this leads to the failure to remove `key_agrif` from the list of active preprocessor keys. ==== Fix The incorrect instructions for preprocessor-key management by `makenemo` described above could be avoided in scripts source:/utils/CI/sette/sette_reference-configurations.sh and source:/utils/CI/sette/sette_test-cases.sh by suppressing the `add_key` keyword if variable `ADD_KEY` does not contain any preprocessor keys. Further, the reporting of incomplete comparisons of output from runs with the `AGIRF_DEMO_ST` and `AGRIF_DEMO_NOAGRIF_ST` model configurations by source:/utils/CI/sette/sette_rpt.sh@11161 should be improved. " Bug closed low CI trunk minor fixed SETTE