Opened 9 months ago

Closed 9 months ago

#2372 closed Bug (fixed)

dev_r12072_MERGE_OPTION2_2019 does not compile without key_iomput

Reported by: smasson Owned by: acc
Priority: low Milestone:
Component: TOP Version: release-4.2
Severity: minor Keywords:
Cc:

Description

Context

the model does not compile without key_iomput… :-(

Analysis

1) the two following routines include a "USE xios" and use several xios routines that are not "protected" by "#if defined key_iomput"

  • src/OCE/DIA/diadetide.F90
  • src/OCE/DIA/diamlr.F90

We try to avoid as much as possible to use directly xios routines outside of iom.F90

2) In iom.F90

  • cpp instructions are missing in iom_init_closedef
    +#if defined key_iomput
           CALL xios_close_context_definition()
           CALL xios_update_calendar( 0 )
    +#endif
    
  • dummy routine is missing for iom_update_file_name
           IF( .FALSE. )   WRITE(numout,*)  cdname   ! useless test to avoid compilation warnings
        END SUBROUTINE iom_context_finalize
    -
    +
    +   SUBROUTINE iom_update_file_name( cdid )
    +      CHARACTER(LEN=*), INTENT(in) ::   cdid
    +      IF( .FALSE. )   WRITE(numout,*)  cdid   ! useless test to avoid compilation warnings
    +   END SUBROUTINE iom_update_file_name
     #endif
    


Fix

Sorry, I cannot access a ssh connexion. could you please do these commits?

Commit History (1)

ChangesetAuthorTimeChangeLog
12345acc2020-01-28T15:26:14+01:00

Branch dev_r12072_MERGE_OPTION2_2019. Fixed ticket #2372. Changes to enable compilation without key_iomput

Change History (3)

comment:1 Changed 9 months ago by acc

  • Owner changed from systeam to acc
  • Status changed from new to assigned

comment:2 Changed 9 months ago by acc

In 12345:

Branch dev_r12072_MERGE_OPTION2_2019. Fixed ticket #2372. Changes to enable compilation without key_iomput

comment:3 Changed 9 months ago by acc

  • Resolution set to fixed
  • Status changed from assigned to closed
Note: See TracTickets for help on using tickets.