New URL for NEMO forge!   http://forge.nemo-ocean.eu

Since March 2022 along with NEMO 4.2 release, the code development moved to a self-hosted GitLab.
This present forge is now archived and remained online for history.
#2399 (Bdy arrays are filled out of their bounds if bdy data is taken at initial step) – NEMO

Opened 4 years ago

Closed 4 years ago

#2399 closed Bug (fixed)

Bdy arrays are filled out of their bounds if bdy data is taken at initial step

Reported by: jchanut Owned by: systeam
Priority: low Milestone:
Component: BDY Version: trunk
Severity: minor Keywords:
Cc:

Description

Context

bdydta module with initial state as boundary data

Analysis

if nn_dyn2d_dta==0, 2d boundary data arrays are allocated over rim points only (and no matter the use of frs for barotropic variables which is an other error). However these are filled over the whole open boundary set of points later on which causes an out of bound error.

Fix

Restrict boundary data initialization to rim points only in bdy_dta as a quick remedy.

Commit History (1)

ChangesetAuthorTimeChangeLog
12547smasson2020-03-13T11:12:08+01:00

trunk: out-of-bounds in bdydta, see #2399

Change History (3)

comment:1 Changed 4 years ago by smasson

We also saw this bug with Gaston last Friday...

Ssh is always defined and use only on the rim so it is easy, however u2d et v2d can be defined over the whole boundary if ln_full_vel = T (see definition of iszdim in bdy_dta_init). So we were thinking to define the loop upper limit with a size to make sure we always have to proper loop size...

I don't really see the need of the variable ilen1...

comment:2 Changed 4 years ago by smasson

In 12547:

Error: Failed to load processor CommitTicketReference
No macro or processor named 'CommitTicketReference' found

comment:3 Changed 4 years ago by smasson

  • Resolution set to fixed
  • Status changed from new to closed

fixed in [12547]

Note: See TracTickets for help on using tickets.