New URL for NEMO forge!   http://forge.nemo-ocean.eu

Since March 2022 along with NEMO 4.2 release, the code development moved to a self-hosted GitLab.
This present forge is now archived and remained online for history.
#2531 (Incorrect character length declaration in diaobs) – NEMO

Opened 4 years ago

Closed 3 years ago

#2531 closed Bug (fixed)

Incorrect character length declaration in diaobs

Reported by: hadcv Owned by: hadcv
Priority: low Milestone: Unscheduled
Component: OBS Version: trunk
Severity: minor Keywords: diaobs, obs_settypefiles
Cc:

Description (last modified by hadcv)

The dummy (cobstypes) and actual (cobstypesprof, cobstypessurf) arguments of obs_settypefiles have inconsistent character length declarations, which causes a segfault in GYRE. This was likely missed from 13216.

Fix

Use lca in the cobstypes declaration in ​diaobs.F90:

- CHARACTER(len=6), DIMENSION(ntypes), INTENT(INOUT) :: &
     &                   cobstypes   ! Out appended list of obs type

+ CHARACTER(len=lca), DIMENSION(ntypes), INTENT(INOUT) :: &
     &                     cobstypes   ! Out appended list of obs type

Commit History (0)

(No commits)

Change History (2)

comment:1 Changed 4 years ago by hadcv

  • Description modified (diff)

comment:2 Changed 3 years ago by hadcv

  • Resolution set to fixed
  • Status changed from new to closed

Closing as this has been fixed by [14056], which replaces len=lca in the declarations for cobstypesprof/cobstypessurf with len=8.

Note: See TracTickets for help on using tickets.