Opened 7 weeks ago

#2541 new Defect

management of usr_*.F90

Reported by: mathiot Owned by: systeam
Priority: low Milestone:
Component: MULTIPLE Version: trunk
Severity: minor Keywords:
Cc:

Description

Context and suggestions

After the ticket #2515, I realised, that:

  • usr_def_fmask code cannot be switch off/on in the namelist. So it is always 'on'. ⇒ it means it is not a 'usr' code but a 'compulsory' code. Probably a namelist logical flag to activate it 'on' or 'off' could be useful. (I didn't check the call to the other 'usr' code).
227         ! User defined alteration of fmask (use to reduce ocean transport in specified straits)
228         ! --------------------------------
229         !
230         CALL usr_def_fmask( cn_cfg, nn_cfg, fmask )
231         !
232      END SUBROUTINE dom_msk
  • in general, 'usr' modules are doing something by default. Should the default be: the usr code is doing stoping the model (everything commented to not loose code with a ctl_stop (STOP,'empty usr routine: something is not right. please check namelist_cfg or usr_xxxx routines') and always activated it in namelist_ref. This will enforce the user to decide (switch on the read of domain_cfg file in namelist_ctl for example) or write in the 'usr' module what he really wants. A bit like in the namelist_ref where option are set to OFF or .false. ?

Commit History (0)

(No commits)

Change History (0)

Note: See TracTickets for help on using tickets.