File OCE/OBS/obs_fbm.F90 custom precision #mixedprecision

[sparonuz]

Context

In file File OCE/OBS/obs_fbm.F90 there are the following lines

   IMPLICIT NONE
   PUBLIC

   ! Type kinds for feedback data.

   INTEGER, PARAMETER :: fbsp = SELECTED_REAL_KIND( 6, 37) !: single precision
   INTEGER, PARAMETER :: fbdp = SELECTED_REAL_KIND(12,307) !: double precision

These are basically redefining the same precision (singe/double) already defined (publicly) in file OCE/par_kind.F90

   INTEGER, PUBLIC, PARAMETER ::   sp = SELECTED_REAL_KIND( 6, 37)   !: single precision (real 4)
   INTEGER, PUBLIC, PARAMETER ::   dp = SELECTED_REAL_KIND(12,307)   !: double precision (real 8)

If this was not made for a matter of flexibility, the definition should be removed and the global parameter should be used instead.

Proposal

I propose to add a

use par_kind

at the beginning of the file and change all the variables defined as

REAL(KIND=fbdp), DIMENSION [...] :: my_var1
REAL(KIND=fbsp), DIMENSION [...] :: my_var2

to

REAL(KIND=dp), DIMENSION [...] :: my_var1
REAL(KIND=sp), DIMENSION [...] :: my_var2

...

[sparonuz]

In 14932:

Error: Failed to load processor CommitTicketReference

No macro or processor named 'CommitTicketReference' found