Opened 12 years ago

Closed 11 years ago

Last modified 3 years ago

#364 closed Bug (fixed)

wrong sign in lbc_lnk for gradients in limadv.F90

Reported by: dupontf Owned by: nemo
Priority: low Milestone:
Component: LIM3 Version: release-3.0
Severity: Keywords: LIM* NP_folding release-3.0
Cc:

Description

Hi all,

Just a minor bug. In limadv.F90 one has several calls to ensure the proper exchange of data between the different CPUs, the cyclic boundary condition if needed, and the north fold of the domain if also required:

      !-- Lateral boundary conditions
      CALL lbc_lnk( psm , 'T', 1. )
      CALL lbc_lnk( ps0 , 'T', 1. )
      CALL lbc_lnk( psx , 'T', 1. )
      CALL lbc_lnk( psxx, 'T', 1. )
      CALL lbc_lnk( psy , 'T', 1. )
      CALL lbc_lnk( psyy, 'T', 1. )
      CALL lbc_lnk( psxy, 'T', 1. )

Well, because psx and psy are gradients of ps0, they should be treated as velocity, i.e., with a sign change through the north fold. So the correct calls should be for psx and psy:

      CALL lbc_lnk( psx , 'T',-1. )
      CALL lbc_lnk( psy , 'T',-1. )

Fred.

Commit History (1)

ChangesetAuthorTimeChangeLog
1510ctlod2009-07-21T09:43:22+02:00

wrong sign in lbc_lnk for psx and psy gradients, see ticket: #364

Change History (8)

comment:1 Changed 11 years ago by gm

We definitively agree with this bug report. Change will be made for release 3.2

gurvan

comment:2 Changed 11 years ago by gm

N.B. 1 : This bug concerns both LIM 2 and LIM 3. limadv.F90 and limadv_2.F90 have both to be corrected.
N.B. 2 : To be convinced of the reality of this bug, just plot the 1st moments of any fields (found in the ice restart file), they actually change sign at the north fold boundary.

comment:3 Changed 11 years ago by ctlod

  • Resolution set to fixed
  • Status changed from new to closed

comment:4 Changed 4 years ago by nicolasmartin

  • Keywords NP_folding added; fold removed

comment:5 Changed 4 years ago by nicolasmartin

  • Keywords north removed

comment:6 Changed 3 years ago by nemo

  • Keywords LIM* added

comment:7 Changed 3 years ago by nemo

  • Keywords release-3.0 added

comment:8 Changed 3 years ago by frrh

In 9262:

Add code from Julien's Met Office GMED ticket 364 to output
details relating to tracer conservation checks.

Command:
svn merge -r 9204:9260
svn+ssh://forge.ipsl.jussieu.fr/ipsl/forge/projets/nemo/svn/branches/NERC/dev_r5518_GO6_conserv_check_up

Note: See TracTickets for help on using tickets.