Opened 12 years ago

Closed 11 years ago

Last modified 3 years ago

#366 closed Bug (fixed)

sbot_min not properly used in hybrid coordinate option (zgr_sco module in domzgr)

Reported by: rachel.furner Owned by: nemo
Priority: low Milestone:
Component: OCE Version: release-3.0
Severity: Keywords:
Cc:

Description

I think sbot_min is applied in the wrong place, meaning that the levels are defined using sbot_min as a minimum depth but then points are masked out so the code actually has points shallower than sbot_min.

In the subroutine scobot is defined to be the bathymetry after sbot_max is applied (but before sbot_min is applied). The minimum depth is then applied to the bathymetry, along with the r_max smoothing and the levels are defined on this altered bathymetry. Then near the end of the subroutine, masking is applied to reintroduce the scobot bathymetry, but as this was set before sbot_min was applied the masking reintroduces areas shallower than sbot_min. I think the lines:

DO jj = 1, jpj

DO ji = 1, jpi

zenv(ji,jj) = MAX( bathy(ji,jj), sbot_min )

END DO

END DO

should come before the line

scobot(:,:) = bathy(:,:)

This way the bathymetry which is reset at the end of the subroutine is the minimised and maximised bathymetry, and there will be no points where the btahymetry is shallower than sbot_min.

Commit History (1)

ChangesetAuthorTimeChangeLog
1639rblod2009-10-05T19:06:17+02:00

Fix some bigs in s-coordinate, see ticket #366 and #380

Change History (2)

comment:1 Changed 11 years ago by rblod

  • Resolution set to fixed
  • Status changed from new to closed

comment:2 Changed 3 years ago by marc

In 9164:

GMED ticket 366: fix restartability for MEDUSA

Note: See TracTickets for help on using tickets.