New URL for NEMO forge!   http://forge.nemo-ocean.eu

Since March 2022 along with NEMO 4.2 release, the code development moved to a self-hosted GitLab.
This present forge is now archived and remained online for history.
#381 (bugs in "subroutine zgr_sco") – NEMO

Opened 15 years ago

Closed 14 years ago

#381 closed Bug (fixed)

bugs in "subroutine zgr_sco"

Reported by: hliu Owned by: nemo
Priority: high Milestone:
Component: OCE Version: trunk
Severity: Keywords:
Cc:

Description

There are some bugs here in all the former versions of nemo I can see (include v3.1). These bugs can generate incorrect value of gdep3w which is used in dynhpg. The modifications are listed below:
1) ==================================================
!! H. Liu, Jan 2009
!! esigw( 1 ) = esigw( 2 )
!! esigt(jpk) = esigt(jpkm1)

esigw( 1 ) = 2.0_wp * (gsigt(1) - gsigw(1))
esigt(jpk) = 2.0_wp * (gsigt(jpk) - gsigw(jpk))

2) ==================================================

DO jk = 1, jpk

zcoeft = ( FLOAT(jk) - 0.5 ) / FLOAT(jpkm1)
zcoefw = ( FLOAT(jk) - 1.0 ) / FLOAT(jpkm1)
gdept (:,:,jk) = (scosrf(:,:)+(hbatt(:,:)-hift(:,:))*gsigt(jk)+hift(:,:)*zcoeft)
gdepw (:,:,jk) = (scosrf(:,:)+(hbatt(:,:)-hift(:,:))*gsigw(jk)+hift(:,:)*zcoefw)

!! R. Furnel and H. Liu
! gdep3w(:,:,jk) = (scosrf(:,:)+(hbatt(:,:)-hift(:,:))*gsi3w(jk)+hift(:,:)*zcoefw)

gdep3w(:,:,jk) = (scosrf(:,:)+(hbatt(:,:)-hift(:,:))*gsi3w(jk)+hift(:,:)*zcoeft)

END DO

===============================================================

N.B. The modification of esigt(jpk) is optional and will not affect model results. There is an attachment of the modified domzgr.F90.

Commit History (0)

(No commits)

Attachments (1)

domzgr.F90 (68.5 KB) - added by hliu 15 years ago.

Download all attachments as: .zip

Change History (2)

Changed 15 years ago by hliu

comment:1 Changed 14 years ago by rblod

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.