#382 closed Bug (fixed)
bugs in "subroutine dom_vvl"
| Reported by: | hliu | Owned by: | nemo |
|---|---|---|---|
| Priority: | high | Milestone: | |
| Component: | OCE | Version: | trunk |
| Severity: | Keywords: | VVL | |
| Cc: |
Description
We shouldn't assume that t-level is located exactly at the middle of the two neighbor w-levels. So, we cannot use:
DO jk = 2, jpk
fse3w (:,:,jk) = 0.5 * ( fse3t(:,:,jk-1) + fse3t(:,:,jk) )
fse3uw(:,:,jk) = 0.5 * ( fse3u(:,:,jk-1) + fse3u(:,:,jk) )
fse3vw(:,:,jk) = 0.5 * ( fse3v(:,:,jk-1) + fse3v(:,:,jk) )
END DO
The bugs above will induce serious conservation issue with vvl invoked.
I would suggest to use the following form:
DO jk = 1, jpkm1
fse3t(:,:,jk) = fsve3t(:,:,jk) * ( 1 + sshn(:,:) * mut(:,:,jk) )
fse3u(:,:,jk) = fsve3u(:,:,jk) * ( 1 + sshu(:,:) * muu(:,:,jk) )
fse3v(:,:,jk) = fsve3v(:,:,jk) * ( 1 + sshv(:,:) * muv(:,:,jk) )
fse3f(:,:,jk) = fsve3f(:,:,jk) * ( 1 + zsshf(:,:) * muf(:,:,jk) )
fse3w(:,:,jk) = fsve3w(:,:,jk) * ( 1 + sshn(:,:) * mut(:,:,jk) )
fse3uw(:,:,jk) = fsve3uw(:,:,jk) * ( 1 + sshu(:,:) * muu(:,:,jk) )
fse3vw(:,:,jk) = fsve3vw(:,:,jk) * ( 1 + sshv(:,:) * muv(:,:,jk) )
END DO
A modified version of domvvl.F90 is attached here.
Commit History (0)
(No commits)
Attachments (1)
Change History (3)
Changed 15 years ago by hliu
comment:1 Changed 15 years ago by rblod
- Resolution set to fixed
- Status changed from new to closed
comment:2 Changed 8 years ago by nicolasmartin
- Keywords VVL added; vvl removed
Fixed in the trunk with the new VVL organisation