New URL for NEMO forge!   http://forge.nemo-ocean.eu

Since March 2022 along with NEMO 4.2 release, the code development moved to a self-hosted GitLab.
This present forge is now archived and remained online for history.
#424 (missing lbc_lnk in sbcmod) – NEMO

Opened 15 years ago

Closed 15 years ago

#424 closed Bug (invalid)

missing lbc_lnk in sbcmod

Reported by: molines Owned by: nemo
Priority: high Milestone:
Component: OCE Version: v3.1
Severity: Keywords: SBC
Cc:

Description

This bug have been fixed by the NOCS people (Beverly or Andrew) :
It seems that lbc_lnk(emp, 'T',1) at the end of sbcmod (see attached file) fixes problems related to north fold boundary in ORCA configuration.

We discover that this fix is also required for open boundary configuration (eg PERIANT8) when running in MPP.

I think then that this statement should be restored in the standard version !

Commit History (0)

(No commits)

Attachments (1)

sbcmod.F90 (14.2 KB) - added by molines 15 years ago.
sbcmod fix NOCS bug fix (lbc_lnk(emp ...))

Download all attachments as: .zip

Change History (3)

Changed 15 years ago by molines

sbcmod fix NOCS bug fix (lbc_lnk(emp ...))

comment:1 Changed 15 years ago by smasson

Hello,

Do you know why you need a call to lbc_lnk for emp?
I had a quick look to the code, and all loops defining emp are done for all points (1->jpi and 1->jpj).
In any case, I think, the call to lbc_lnk should be done just after the pice of code that does not compute emp everywhere and not at the end of lbc_lnk.

Did you check if your input file (or the online interpolation) is properly defined (a call to lbc_lnk just after the reading part does not change the input fields). In your attached file we can read:

   !! NOCS modification to get rid of bad input data

When we wrote iom_get, we decided to let the user take care of his input files as it was complicated and not really user-friendly to put a call of lbc_lnk within iom_get (you need to know the type of point and if you change the sign or not).
I don't think it is a good solution to introduce a code modification for a specific input file problem on a specific variable

seb

comment:2 Changed 15 years ago by smasson

  • Resolution set to invalid
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.