Opened 10 years ago

Closed 10 years ago

#715 closed Bug (fixed)

Definition of obctmsk in obcini.F90 depending on a IF-condition

Reported by: dupontf Owned by: nemo
Priority: low Milestone:
Component: OCE Version: release-3.2
Severity: Keywords:
Cc:

Description

in obcini.F90, obctmsk is defined only if ln_vol_cst or lk_dynspg_flt are true (line 378). However it is used in sshwzv.F90 (line 160) whatever the value of ln_vol_cst or lk_dynspg_flt. This means that we run into the possibility that it is initialized to random values.

This field and accompanying variables should be defined at all times. Therefore, I suggest removing the IF-condition surrounding the definition.

Just a suggestion: the IF-condition for the calculation of obcsurftot is OK, but since it is computed just one and is pretty quick to compute, why not removing the condition?

Fred.

Commit History (1)

ChangesetAuthorTimeChangeLog
2149rblod2010-10-04T15:53:47+02:00

Compute obctmsk en all cases, see ticket #715

Change History (1)

comment:1 Changed 10 years ago by rblod

  • Resolution set to fixed
  • Status changed from new to closed

I follow the suggestion .. Merci Rachid

Note: See TracTickets for help on using tickets.