Opened 9 years ago

Closed 8 years ago

Last modified 4 years ago

#834 closed Bug (fixed)

runoff in the depth

Reported by: rblod Owned by: nemo
Priority: low Milestone:
Component: OCE Version: release-3.4
Severity: Keywords: TRA runoffs namelists
Cc:

Description

In trasbc line 206, I guess zdep should be calculated inside the test IF ( rnf(ji,jj) /= 0._wp ) since h_rnf can be zero (where there are no runoff) when activating ln_rnf_depth

DO jj = 2, jpj 
     DO ji = fs_2, fs_jpim1
	   zdep = 1. / h_rnf(ji,jj)
	   zdep = zfact * zdep 
	   IF ( rnf(ji,jj) /= 0._wp ) THEN
...
	   ENDIF
      END DO 
 END DO 

Commit History (3)

ChangesetAuthorTimeChangeLog
3691gm2012-11-27T18:20:52+01:00

trunk: #834 runoff in depth bug + removal of useless lbc_lnk communication

3682vichi2012-11-27T16:12:51+01:00

Corrected a bug when checking the values of the river depth from a given input file in sbcrnf.F90 It was possible to have zeroes that generated a division by zero as in ticket #834

2784charris2011-06-22T16:23:02+02:00

Increase character limit for runoff coefficient file, see #834

Change History (5)

comment:1 Changed 8 years ago by vichi

  • Resolution set to fixed
  • Status changed from new to closed
  • Version changed from nemo_v3_3_1 to nemo_v3_4

The presence of zeroes should be done in SBC/sbcrnf.F90 when the river depth is read from the file. However it was not properly implemented and it has been fixed in revision 3682

comment:2 Changed 8 years ago by gm

an unecessary lbc_lnk on after fields has also been removed 

see Changeset 3691

 

comment:3 Changed 4 years ago by nicolasmartin

  • Milestone 2011 Stream 0: Coastal Ocean Ready deleted

Milestone 2011 Stream 0: Coastal Ocean Ready deleted

comment:4 Changed 4 years ago by nicolasmartin

  • Keywords TRA added; trasbc removed

comment:5 Changed 4 years ago by nicolasmartin

  • Keywords runoffs namelists added; ln_rnf_depth removed
Note: See TracTickets for help on using tickets.